Bug 74943 - [Coverity] Fix leak in V8HTMLDocument
Summary: [Coverity] Fix leak in V8HTMLDocument
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Greg Billock
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-12-20 10:55 PST by Greg Billock
Modified: 2011-12-20 15:46 PST (History)
4 users (show)

See Also:

Attachments
Patch (1.50 KB, patch)
2011-12-20 10:55 PST, Greg Billock 		no flags Details | Formatted Diff | Diff
Patch (2.17 KB, patch)
2011-12-20 12:01 PST, Greg Billock 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Greg Billock 2011-12-20 10:55:03 PST 
[Coverity] Fix leak in V8HTMLDocument
Comment 1 Greg Billock 2011-12-20 10:55:42 PST 
Created attachment 120044 [details]
Patch
Comment 2 Adam Barth 2011-12-20 11:43:24 PST 
Comment on attachment 120044 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=120044&action=review

> Source/WebCore/bindings/v8/custom/V8HTMLDocumentCustom.cpp:156
> +                delete[] params;

We should use OwnArrayPtr instead of manual delete.
Comment 3 Greg Billock 2011-12-20 12:00:14 PST 
Comment on attachment 120044 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=120044&action=review

>> Source/WebCore/bindings/v8/custom/V8HTMLDocumentCustom.cpp:156
>> +                delete[] params;
> 
> We should use OwnArrayPtr instead of manual delete.

Done.
Comment 4 Greg Billock 2011-12-20 12:01:39 PST 
Created attachment 120055 [details]
Patch
Comment 5 WebKit Review Bot 2011-12-20 15:46:18 PST 
Comment on attachment 120055 [details]
Patch

Clearing flags on attachment: 120055

Committed r103358: <http://trac.webkit.org/changeset/103358>
Comment 6 WebKit Review Bot 2011-12-20 15:46:22 PST 
All reviewed patches have been landed.  Closing bug.