Bug 74932 - [Qt][WK2] Add ArgumentCoder functions for size_t.
Summary: [Qt][WK2] Add ArgumentCoder functions for size_t.
Status: RESOLVED INVALID
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit2 (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Zeno Albisser
URL:
Keywords:
Depends on:
Blocks: 74931
  Show dependency treegraph
 
Reported: 2011-12-20 07:43 PST by Zeno Albisser
Modified: 2011-12-21 08:37 PST (History)
7 users (show)

See Also:


Attachments
patch for review. (2.22 KB, patch)
2011-12-20 09:05 PST, Zeno Albisser
hausmann: review-
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Zeno Albisser 2011-12-20 07:43:12 PST
This allows the WebProcess/UIProcess to exchange data of the size of a native pointer.
Comment 1 Zeno Albisser 2011-12-20 09:05:00 PST
Created attachment 120035 [details]
patch for review.
Comment 2 Simon Hausmann 2011-12-20 11:46:03 PST
Comment on attachment 120035 [details]
patch for review.

View in context: https://bugs.webkit.org/attachment.cgi?id=120035&action=review

> Source/WebKit2/Shared/qt/ArgumentCodersQt.cpp:100
> +#if WTF_USE_JSVALUE64

That doesn't sound like the right macro to use. Technically it refers to an implementation detail of JSC.

I also think uintptr_t is a better type to use than size_t, and with a bit of template specialization you should be able to figure out the size of uintptr_t, instead of using the macro.

I see what you're trying to use this for, but I don't think it's the right thing to do. I'll comment on the other bug about the use-case.
Comment 3 Zeno Albisser 2011-12-20 12:38:37 PST
I was in doubt about that myself. But it seemed to be very straightforward, and i was - honestly - curious about the feedback. ;-)
Another option would be to use a QUuid. Do you think that would be a better approach?
Comment 4 Zeno Albisser 2011-12-21 08:37:23 PST
Assuming that we are not going with the pointer magic we will not need this functionality.
Therefore i am closing this bug again.