Bug 74920 - [EFL] Add 'Select All' option to context menus in WebKit-EFL.
Summary: [EFL] Add 'Select All' option to context menus in WebKit-EFL.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit EFL (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC Linux
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-12-20 04:20 PST by Michal Pakula vel Rutka
Modified: 2011-12-21 14:44 PST (History)
5 users (show)

See Also:

Attachments
proposed patch (6.12 KB, patch)
2011-12-20 04:23 PST, Michal Pakula vel Rutka 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Michal Pakula vel Rutka 2011-12-20 04:20:41 PST 
Enable 'Select All' option to context menus called on input fields in WebKit-EFL as it is enabled in GTK and QT ports.
Comment 1 Michal Pakula vel Rutka 2011-12-20 04:23:15 PST 
Created attachment 120007 [details]
proposed patch
Comment 2 Raphael Kubo da Costa (:rakuco) 2011-12-20 05:28:54 PST 
Looks OK, even though I don't know this part of the code. Does it need bug 74179 to work properly?
Comment 3 Gyuyoung Kim 2011-12-20 19:47:00 PST 
LGTM too.
Comment 4 Michal Pakula vel Rutka 2011-12-21 01:02:09 PST 
It is not dependent from any way how we implement context menu, whether it is using 74179 (CROSS_PLATFORM_CONTEXT_MENU=ON) or not. 
Main code is placed in ContextMenuController which is common for all platforms. Only EFL specific code is matching value of ContextMenuItem::ContextMenuItemTagSelectAll with EWK_CONTEXT_MENU_ITEM_SELECT_ALL.
Comment 5 Eric Seidel (no email) 2011-12-21 12:27:42 PST 
Comment on attachment 120007 [details]
proposed patch

OK.
Comment 6 WebKit Review Bot 2011-12-21 14:44:13 PST 
Comment on attachment 120007 [details]
proposed patch

Clearing flags on attachment: 120007

Committed r103455: <http://trac.webkit.org/changeset/103455>
Comment 7 WebKit Review Bot 2011-12-21 14:44:20 PST 
All reviewed patches have been landed.  Closing bug.