RESOLVED FIXED 74920
[EFL] Add 'Select All' option to context menus in WebKit-EFL. 
https://bugs.webkit.org/show_bug.cgi?id=74920
Summary [EFL] Add 'Select All' option to context menus in WebKit-EFL.
Michal Pakula vel Rutka
Reported 2011-12-20 04:20:41 PST
Enable 'Select All' option to context menus called on input fields in WebKit-EFL as it is enabled in GTK and QT ports.
Attachments
proposed patch (6.12 KB, patch)
2011-12-20 04:23 PST, Michal Pakula vel Rutka 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Michal Pakula vel Rutka
Comment 1 2011-12-20 04:23:15 PST
Created attachment 120007 [details] proposed patch
Raphael Kubo da Costa (:rakuco)
Comment 2 2011-12-20 05:28:54 PST
Looks OK, even though I don't know this part of the code. Does it need bug 74179 to work properly?
Gyuyoung Kim
Comment 3 2011-12-20 19:47:00 PST
LGTM too.
Michal Pakula vel Rutka
Comment 4 2011-12-21 01:02:09 PST
It is not dependent from any way how we implement context menu, whether it is using 74179 (CROSS_PLATFORM_CONTEXT_MENU=ON) or not. Main code is placed in ContextMenuController which is common for all platforms. Only EFL specific code is matching value of ContextMenuItem::ContextMenuItemTagSelectAll with EWK_CONTEXT_MENU_ITEM_SELECT_ALL.
Eric Seidel (no email)
Comment 5 2011-12-21 12:27:42 PST
Comment on attachment 120007 [details] proposed patch OK.
WebKit Review Bot
Comment 6 2011-12-21 14:44:13 PST
Comment on attachment 120007 [details] proposed patch Clearing flags on attachment: 120007 Committed r103455: <http://trac.webkit.org/changeset/103455>
WebKit Review Bot
Comment 7 2011-12-21 14:44:20 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.