Bug 74896 – webkitpy: remove port.executive, port.filesystem, port.user properties

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Dirk Pranke]

webkitpy: remove port.executive, port.filesystem, port.user properties

[Dirk Pranke]

Created attachment 119936 [details]
Patch

[Eric Seidel (no email)]

Comment on attachment 119936 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=119936&action=review

OK.  I'm surprised the diff is this small.

> Tools/Scripts/webkitpy/layout_tests/models/test_configuration.py:43
> -        build_type = port.options.configuration.lower()
> +        build_type = port.get_option('configuration').lower()

I think the previous version was cleaner.  Certainly for testing code where we're not trying to have dynamic support for different option configurations.

[Dirk Pranke]

Created attachment 119953 [details]
remove TestConfiguration.from_port()

[Dirk Pranke]

(In reply to comment #2)
> (From update of attachment 119936 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=119936&action=review
> 
> OK.  I'm surprised the diff is this small.
> 

Yeah, there weren't too many references to it.

> > Tools/Scripts/webkitpy/layout_tests/models/test_configuration.py:43
> > -        build_type = port.options.configuration.lower()
> > +        build_type = port.get_option('configuration').lower()
> 
> I think the previous version was cleaner.  Certainly for testing code where we're not trying to have dynamic support for different option configurations.

This comment caused me to actually look at what was going on in this routine. It turns out Dimitri had refactored an earlier version of the TestConfiguration constructor and didn't quite get the refactoring as clean as it could be. By finishing that (and updating Port.test_configuration() to just call the 4-arg constructor directly) I can delete this classmethod and better encapsulate things, so it's even cleaner now.

[Eric Seidel (no email)]

Comment on attachment 119953 [details]
remove TestConfiguration.from_port()

OK.

[Dirk Pranke]

Committed r103289: <http://trac.webkit.org/changeset/103289>