Bug 74890 – Web Inspector: CodeGeneratorInspector.py: generate anonymous types.

• Status: RESOLVED
• Resolution: FIXED
• Component: Web Inspector (Deprecated)

[Peter Rybin]

Some types are anonymous in Inspector.JSON.
Provide type-safe API for them too.

[Peter Rybin]

Created attachment 119923 [details]
Patch

[Peter Rybin]

Created attachment 119924 [details]
Sample output

[Peter Rybin]

Created attachment 119926 [details]
Sample output InspectorFrontend.h

[Pavel Feldman]

Comment on attachment 119923 [details]
Patch

Looks good. What does it do?

[Peter Rybin]

(In reply to comment #4)
> (From update of attachment 119923 [details])
> Looks good. What does it do?

Let me describe it here a bit more.

In general it generates now C++ type for anonymous object types from JSON. It takes a name from the type declaration site, usually a parameter name. This all is explained comments in generated file. Also all generated types now refer to other generated types in setter methods — but this is commented out in generated code for now. All necessary forward declarations are also added. Anonymous enums are also generated, but they are in comments too, because we didn't have solution about form the enums should have in C++ API.

Internally:
The change reorganizes type bindings — a polymorphous "code generator" object is factored out from binding.
A helper class Writer is added to allow generating code with ajustable indentations and to support insertion points where additional code can be inserted retroactively.
ForwardListener class is used for preparing necessary forward declarations.
AdHocTypeContext conception is a speculative abstract class that is needed wherever anonymous type can emerge.

[Yury Semikhatsky]

(In reply to comment #5)
> (In reply to comment #4)
> > (From update of attachment 119923 [details] [details])
> > Looks good. What does it do?
> 
> Let me describe it here a bit more.
> 
> In general it generates now C++ type for anonymous object types from JSON. It takes a name from the type declaration site, usually a parameter name. This all is explained comments in generated file. Also all generated types now refer to other generated types in setter methods — but this is commented out in generated code for now. All necessary forward declarations are also added. Anonymous enums are also generated, but they are in comments too, because we didn't have solution about form the enums should have in C++ API.
> 
> Internally:
> The change reorganizes type bindings — a polymorphous "code generator" object is factored out from binding.
> A helper class Writer is added to allow generating code with ajustable indentations and to support insertion points where additional code can be inserted retroactively.
> ForwardListener class is used for preparing necessary forward declarations.
> AdHocTypeContext conception is a speculative abstract class that is needed wherever anonymous type can emerge.

This is a good message to be placed into the ChangeLog entry.

[Yury Semikhatsky]

What about typedef'ed types such as BreakpointId and ScriptId? I see them declared but never used afterwards neither in comments nor in code. What prevents you from using them as corresponding parameter types e.g. in the following lines?

void scriptParsed(const String& scriptId, const String& url, int startLine, int startColumn, int endLine, int endColumn, const bool* const isContentScript)
void breakpointResolved(const String& breakpointId, /*PassRefPtr<TypeBuilder::Debugger::Location>*/ PassRefPtr<InspectorObject> location);

[Peter Rybin]

Created attachment 120175 [details]
Patch

[Peter Rybin]

Yury, you have a very sharp eye. Indeed this typedefs were intended for use as parameter types to make client code more consistent. The answer is that I just didn't have time to do it yet and that's in my TODO. I don't think it's a high-pri task right now.

(In reply to comment #7)
> What about typedef'ed types such as BreakpointId and ScriptId? I see them declared but never used afterwards neither in comments nor in code. What prevents you from using them as corresponding parameter types e.g. in the following lines?
> 
> void scriptParsed(const String& scriptId, const String& url, int startLine, int startColumn, int endLine, int endColumn, const bool* const isContentScript)
> void breakpointResolved(const String& breakpointId, /*PassRefPtr<TypeBuilder::Debugger::Location>*/ PassRefPtr<InspectorObject> location);

[WebKit Review Bot]

Comment on attachment 120175 [details]
Patch

Clearing flags on attachment: 120175

Committed r103503: <http://trac.webkit.org/changeset/103503>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.