You need to
before you can comment on or make changes to this bug.
There are some issues mentioned by Nikolas Zimmermann after the patch got reviewed and committed. This bug is a follow up that fixes those issues.
Created an attachment (id=120014) [details]
The spec seems to have been updated to use 1 by 1 as the default mesh. I've also updated that and added some comments.
Created an attachment (id=120018) [details]
Using the StringBuilder only inside the CachedShader.cpp file.
(From update of attachment 120018 [details])
View in context: https://bugs.webkit.org/attachment.cgi?id=120018&action=review
Much nicer, thanks a lot. r=me with a few comments:
> +const char* CustomFilterShader::defaultFragmentShaderString =
> + "precision mediump float;\n" \
I admit, I like the other solution much more now :-)
It's much more readable, would you mind updating it once again?
> + static const char* defaultVertexShaderString;
> + static const char* defaultFragmentShaderString;
This could be removed again using this SHADER technique.
Landed in r103535. Closing the bug.