Bug 74840 – [CSS Shaders] Follow up bug to fix issues mentioned in comment 23 from bug 73317

• Status: RESOLVED
• Resolution: FIXED
• Component: Layout and Rendering

[Alexandru Chiculita]

There are some issues mentioned by Nikolas Zimmermann after the patch got reviewed and committed. This bug is a follow up that fixes those issues.
https://bugs.webkit.org/show_bug.cgi?id=73317#c23

[Alexandru Chiculita]

Created attachment 120014 [details]
Patch V1

The spec seems to have been updated to use 1 by 1 as the default mesh. I've also updated that and added some comments.

[Alexandru Chiculita]

Created attachment 120018 [details]
Patch V2

Using the StringBuilder only inside the CachedShader.cpp file.

[Nikolas Zimmermann]

Comment on attachment 120018 [details]
Patch V2

View in context: https://bugs.webkit.org/attachment.cgi?id=120018&action=review

Much nicer, thanks a lot. r=me with a few comments:

> Source/WebCore/platform/graphics/filters/CustomFilterShader.cpp:51
> +const char* CustomFilterShader::defaultFragmentShaderString =
> +        "precision mediump float;\n" \

I admit, I like the other solution much more now :-)
It's much more readable, would you mind updating it once again?

> Source/WebCore/platform/graphics/filters/CustomFilterShader.h:79
> +    static const char* defaultVertexShaderString;
> +    static const char* defaultFragmentShaderString;

This could be removed again using this SHADER technique.

[Alexandru Chiculita]

Landed in r103535. Closing the bug.