Bug 74839 - [BlackBerry] remove one file related to multipart from the BlackBerry build system
Summary: [BlackBerry] remove one file related to multipart from the BlackBerry build s...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Platform (show other bugs)
Version: 528+ (Nightly build)
Hardware: Other Other
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks: 73144
  Show dependency tree / graph
 
Reported: 2011-12-18 23:04 PST by Chris.Guan
Modified: 2011-12-19 10:08 PST (History)
6 users (show)

See Also:

Attachments
Patch (1.39 KB, patch)
2011-12-18 23:26 PST, Chris.Guan 		no flags Details | Formatted Diff | Diff
Patch (1.54 KB, patch)
2011-12-19 02:35 PST, Chris.Guan 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Chris.Guan 2011-12-18 23:04:15 PST 
platform/network/blackberry/MultipartResponseDelegate.h
platform/network/blackberry/MultipartResponseDelegate.cpp

MultipartResponseDelegate files will not upstream any more, So remove them from build system first.
Comment 1 Chris.Guan 2011-12-18 23:26:03 PST 
Created attachment 119827 [details]
Patch
Comment 2 Daniel Bates 2011-12-19 00:11:25 PST 
Comment on attachment 119827 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=119827&action=review

> Source/WebCore/ChangeLog:8
> +        platform/network/blackberry/MultipartResponseDelegate.cpp will be removed and change build system first.
> +
> +        Reviewed by NOBODY (OOPS!).

These should be swapped. That is, the description should be after the Reviewed By line. Additionally, the description doesn't read well.
Comment 3 Chris.Guan 2011-12-19 02:35:58 PST 
Created attachment 119838 [details]
Patch
Comment 4 WebKit Review Bot 2011-12-19 10:07:56 PST 
Comment on attachment 119838 [details]
Patch

Clearing flags on attachment: 119838

Committed r103244: <http://trac.webkit.org/changeset/103244>
Comment 5 WebKit Review Bot 2011-12-19 10:08:00 PST 
All reviewed patches have been landed.  Closing bug.