Bug 74838 - Enable <track> for Mac build
Summary: Enable <track> for Mac build
Alias: None
Product: WebKit
Classification: Unclassified
Component: Media (show other bugs)
Version: 528+ (Nightly build)
Hardware: Mac Unspecified
: P2 Normal
Assignee: Eric Carlson
Keywords: InRadar
Depends on:
Reported: 2011-12-18 23:03 PST by Eric Carlson
Modified: 2012-01-06 16:43 PST (History)
4 users (show)

See Also:

Proposed patch (2.83 KB, patch)
2011-12-18 23:04 PST, Eric Carlson
darin: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Eric Carlson 2011-12-18 23:03:17 PST
Define ENABLE_VIDEO_TRACK and initialize the runtime feature to true;
Comment 1 Eric Carlson 2011-12-18 23:04:01 PST
Created attachment 119821 [details]
Proposed patch
Comment 2 WebKit Review Bot 2011-12-18 23:05:22 PST
Attachment 119821 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/JavaScriptCore/wtf/Platform.h', u'S..." exit_code: 1

Source/WebCore/bindings/generic/RuntimeEnabledFeatures.cpp:177:  Code inside a namespace should not be indented.  [whitespace/indent] [4]
Total errors found: 1 in 5 files

If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Darin Adler 2011-12-18 23:10:46 PST
Comment on attachment 119821 [details]
Proposed patch

No change log here. Turning this on is fine.
Comment 4 Eric Carlson 2011-12-19 07:59:50 PST
Comment 5 Joseph Pecoraro 2012-01-06 16:42:58 PST
The FeatureDefines files are normally identical across all Mac projects (JSC, WC, WK, WK2). This patch missed JavaScriptCore's FeatureDefines file but modified all the others, and modified Platform.h.
Is the JSC diff necessary or was that just missed by accident?
Comment 6 Radar WebKit Bug Importer 2012-01-06 16:43:20 PST