Bug 74834 – Update dropzone implementation per spec update

• Status: RESOLVED
• Resolution: FIXED
• Component: DOM

[Yael]

Per https://bugs.webkit.org/show_bug.cgi?id=58210#c43 the spec has changed, so the webkit implementation needs an update.

[Yael]

Created attachment 119802 [details]
Patch

Update support for dropzone attribute to use file: and string: instead of f: and s:.

[Kenneth Rohde Christiansen]

Comment on attachment 119802 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=119802&action=review

> Source/WebCore/ChangeLog:11
> +        Update support for dropzone attribute to use file: and string: instead of f: and s:. 
> +
> +        No new tests. Existing tests over this and were updated.
> +

Maybe you should say what spec this is part of?

[Yael]

Created attachment 119858 [details]
Patch.

Added link to the spec.

[Tony Chang]

Comment on attachment 119858 [details]
Patch.

View in context: https://bugs.webkit.org/attachment.cgi?id=119858&action=review

> Source/WebCore/dom/Clipboard.cpp:213
> +    if (keyword.length() > 5 && keyword.startsWith("file:"))

Nit: startsWith will check the length for you so you can remove the length() > 5 check.

> Source/WebCore/dom/Clipboard.cpp:216
> +    if (keyword.length() > 7 && keyword.startsWith("string:"))

Remove the length() > 7 check.

[Yael]

Created attachment 119942 [details]
Patch for landing

Thanks for the review, Tony :)

[WebKit Review Bot]

Comment on attachment 119942 [details]
Patch for landing

Clearing flags on attachment: 119942

Committed r103303: <http://trac.webkit.org/changeset/103303>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.

[Tony Chang]

*** Bug 75495 has been marked as a duplicate of this bug. ***