Bug 74827 - KURL::protocolIs() should handle 8-bit strings.
Summary: KURL::protocolIs() should handle 8-bit strings.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Andreas Kling
URL:
Keywords:
Depends on: 74832
Blocks:
  Show dependency tree / graph
 
Reported: 2011-12-18 17:02 PST by Andreas Kling
Modified: 2011-12-18 18:42 PST (History)
1 user (show)

See Also:

Attachments
Patch (2.81 KB, patch)
2011-12-18 17:20 PST, Andreas Kling 		koivisto: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Andreas Kling 2011-12-18 17:02:14 PST 
We're unnecessarily converting to 16-bit strings here.
Comment 1 Andreas Kling 2011-12-18 17:20:53 PST 
Created attachment 119790 [details]
Patch
Comment 2 Darin Adler 2011-12-18 17:39:44 PST 
Comment on attachment 119790 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=119790&action=review

> Source/WebCore/platform/KURL.cpp:1718
> +bool charactersAreProtocol(const CharType* url, const char* protocol)

This should have static on it for the same reason that isLetterMatchIgnoringCase does.
Comment 3 Andreas Kling 2011-12-18 17:40:35 PST 
Committed r103199: <http://trac.webkit.org/changeset/103199>
Comment 4 Andreas Kling 2011-12-18 17:48:53 PST 
(In reply to comment #2)
> (From update of attachment 119790 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=119790&action=review
> 
> > Source/WebCore/platform/KURL.cpp:1718
> > +bool charactersAreProtocol(const CharType* url, const char* protocol)
> 
> This should have static on it for the same reason that isLetterMatchIgnoringCase does.

Can I take that as an rs=you to add it?
Comment 5 Darin Adler 2011-12-18 17:50:36 PST 
Yes.