Bug 74814 - Add a scrolling thread to the scrolling coordinator
Summary: Add a scrolling thread to the scrolling coordinator
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Anders Carlsson
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-12-18 10:42 PST by Anders Carlsson
Modified: 2011-12-19 06:26 PST (History)
7 users (show)

See Also:


Attachments
Patch (14.30 KB, patch)
2011-12-18 10:45 PST, Anders Carlsson
kling: review+
kling: commit-queue-
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Anders Carlsson 2011-12-18 10:42:00 PST
Add a scrolling thread to the scrolling coordinator
Comment 1 Anders Carlsson 2011-12-18 10:45:09 PST
Created attachment 119768 [details]
Patch
Comment 2 Andreas Kling 2011-12-18 10:53:39 PST
Comment on attachment 119768 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=119768&action=review

r=me with the preprocessor guard.

> Source/WebCore/page/mac/ScrollingCoordinatorMac.mm:156
> +    static ScrollingThread& scrollingThread = *new ScrollingThread();

Y U NO DEFINE_STATIC_LOCAL?

> Source/WebKit2/WebProcess/WebPage/EventDispatcher.cpp:92
> +    MutexLocker locker(m_scrollingCoordinatorsMutex);
> +    if (ScrollingCoordinator* scrollingCoordinator = m_scrollingCoordinators.get(pageID).get()) {
> +        PlatformWheelEvent platformWheelEvent = platform(wheelEvent);
> +
> +        if (scrollingCoordinator->handleWheelEvent(platformWheelEvent)) {
> +            sendDidHandleEvent(pageID, wheelEvent);
> +            return;
> +        }
> +    }
> +

This block needs an ENABLE(THREADED_SCROLLING) guard.
Comment 3 Anders Carlsson 2011-12-18 10:56:30 PST
Committed r103180: <http://trac.webkit.org/changeset/103180>
Comment 4 Benjamin Poulain 2011-12-19 03:21:05 PST
Little build fix: http://trac.webkit.org/changeset/103227