RESOLVED FIXED 74808
REGRESSION(r103149): prepare-ChangeLog outputs a warning 
https://bugs.webkit.org/show_bug.cgi?id=74808
Summary REGRESSION(r103149): prepare-ChangeLog outputs a warning
Kentaro Hara
Reported 2011-12-18 03:17:00 PST
After r103149, prepare-ChangeLog outputs the following warning due to missing the prototype declaration of main(). main::main() called too early to check prototype at ./Tools/Scripts/prepare-ChangeLog line 117.
Attachments
Patch (1.11 KB, patch)
2011-12-18 03:19 PST, Kentaro Hara 		ddkilzer: review+
ddkilzer: commit-queue-
DetailsFormatted DiffDiff
patch for commit (2.94 KB, patch)
2011-12-18 05:08 PST, Kentaro Hara 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Kentaro Hara
Comment 1 2011-12-18 03:19:41 PST
Created attachment 119756 [details] Patch
David Kilzer (:ddkilzer)
Comment 2 2011-12-18 05:03:15 PST
Comment on attachment 119756 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=119756&action=review r=me > Tools/Scripts/prepare-ChangeLog:67 > +sub main(); Should be in alphabetical order.
Kentaro Hara
Comment 3 2011-12-18 05:08:18 PST
Created attachment 119759 [details] patch for commit
Kentaro Hara
Comment 4 2011-12-18 05:10:42 PST
(In reply to comment #2) > (From update of attachment 119756 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=119756&action=review > > r=me > > > Tools/Scripts/prepare-ChangeLog:67 > > +sub main(); > > Should be in alphabetical order. Subroutines in this file had been declared in the order in which they defined. I sorted all subroutine declarations in the alphabetical order, and committed. Thanks.
WebKit Review Bot
Comment 5 2011-12-18 06:43:31 PST
Comment on attachment 119759 [details] patch for commit Clearing flags on attachment: 119759 Committed r103171: <http://trac.webkit.org/changeset/103171>
Note You need to log in before you can comment on or make changes to this bug.