Bug 74805 - Move timestamp down from PlatformEvent subclasses to the base class
Summary: Move timestamp down from PlatformEvent subclasses to the base class
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Sam Weinig
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-12-17 23:43 PST by Sam Weinig
Modified: 2011-12-18 11:45 PST (History)
2 users (show)

See Also:


Attachments
Patch (32.08 KB, patch)
2011-12-17 23:45 PST, Sam Weinig
no flags Details | Formatted Diff | Diff
Patch (32.05 KB, patch)
2011-12-17 23:49 PST, Sam Weinig
no flags Details | Formatted Diff | Diff
Patch (34.83 KB, patch)
2011-12-18 11:36 PST, Sam Weinig
andersca: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Sam Weinig 2011-12-17 23:43:34 PST
Move timestamp down from PlatformEvent subclasses to the base class
Comment 1 Sam Weinig 2011-12-17 23:45:05 PST
Created attachment 119753 [details]
Patch
Comment 2 WebKit Review Bot 2011-12-17 23:47:15 PST
Attachment 119753 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCor..." exit_code: 1

Source/WebCore/platform/win/PlatformMouseEventWin.cpp:89:  Extra space before last semicolon. If this should be an empty statement, use { } instead.  [whitespace/semicolon] [5]
Source/WebCore/platform/wx/MouseEventWx.cpp:29:  Alphabetical sorting problem.  [build/include_order] [4]
Total errors found: 2 in 22 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Sam Weinig 2011-12-17 23:49:58 PST
Created attachment 119754 [details]
Patch
Comment 4 WebKit Review Bot 2011-12-17 23:52:45 PST
Attachment 119754 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCor..." exit_code: 1

Source/WebCore/platform/wx/MouseEventWx.cpp:29:  Alphabetical sorting problem.  [build/include_order] [4]
Total errors found: 1 in 22 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 5 Sam Weinig 2011-12-18 11:36:03 PST
Created attachment 119770 [details]
Patch
Comment 6 WebKit Review Bot 2011-12-18 11:38:11 PST
Attachment 119770 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCor..." exit_code: 1

Source/WebCore/platform/wx/MouseEventWx.cpp:29:  Alphabetical sorting problem.  [build/include_order] [4]
Source/WebCore/platform/wx/MouseEventWx.cpp:32:  Alphabetical sorting problem.  [build/include_order] [4]
Total errors found: 2 in 23 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 7 Sam Weinig 2011-12-18 11:45:48 PST
Committed r103181: <http://trac.webkit.org/changeset/103181>