Bug 74793 - CSSPrimitiveValue: Inline getIdent().
Summary: CSSPrimitiveValue: Inline getIdent().
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: CSS (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Andreas Kling
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-12-17 15:08 PST by Andreas Kling
Modified: 2011-12-17 19:26 PST (History)
2 users (show)

See Also:


Attachments
Patch (1.78 KB, patch)
2011-12-17 15:08 PST, Andreas Kling
koivisto: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Andreas Kling 2011-12-17 15:08:12 PST
getIdent() is trivial, and the other getFoo() methods in CSSPrimitiveValue are already inline (excluding those that may set a DOM exception.)
Comment 1 Andreas Kling 2011-12-17 15:08:50 PST
Created attachment 119738 [details]
Patch
Comment 2 Antti Koivisto 2011-12-17 18:55:38 PST
Comment on attachment 119738 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=119738&action=review

> Source/WebCore/css/CSSPrimitiveValue.h:207
> +    int getIdent() const { return m_primitiveUnitType != CSS_IDENT ? 0 : m_value.ident; }

I would prefer equality check.
Comment 3 Andreas Kling 2011-12-17 19:26:13 PST
Committed r103161: <http://trac.webkit.org/changeset/103161>