Bug 74791 - [Qt] Fix QtTestBrowser compilation with QtWidgets module
Summary: [Qt] Fix QtTestBrowser compilation with QtWidgets module
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit Qt (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-12-17 14:06 PST by Adenilson Cavalcanti Silva
Modified: 2011-12-17 19:35 PST (History)
1 user (show)

See Also:


Attachments
Link with libQtWidgets (1.29 KB, patch)
2011-12-17 14:12 PST, Adenilson Cavalcanti Silva
kenneth: review+
kenneth: commit-queue-
Details | Formatted Diff | Diff
Only use QtWidgets module if using Qt5 (1.33 KB, patch)
2011-12-17 17:15 PST, Adenilson Cavalcanti Silva
no flags Details | Formatted Diff | Diff
Only use QtWidgets module if using Qt5, reuse previous test clause (1.38 KB, patch)
2011-12-17 17:22 PST, Adenilson Cavalcanti Silva
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Adenilson Cavalcanti Silva 2011-12-17 14:06:34 PST
Compilation will fail due to missing QT += widgets with current qt5 hash.
Comment 1 Adenilson Cavalcanti Silva 2011-12-17 14:12:15 PST
Created attachment 119735 [details]
Link with libQtWidgets
Comment 2 Kenneth Rohde Christiansen 2011-12-17 15:22:49 PST
Comment on attachment 119735 [details]
Link with libQtWidgets

I think this should only be done with Qt5 right?
Comment 3 Adenilson Cavalcanti Silva 2011-12-17 17:15:02 PST
Created attachment 119742 [details]
Only use QtWidgets module if using Qt5
Comment 4 Adenilson Cavalcanti Silva 2011-12-17 17:22:19 PST
Created attachment 119743 [details]
Only use QtWidgets module if using Qt5, reuse previous test clause
Comment 5 Andreas Kling 2011-12-17 18:20:03 PST
Comment on attachment 119743 [details]
Only use QtWidgets module if using Qt5, reuse previous test clause

rs=me
Comment 6 WebKit Review Bot 2011-12-17 19:35:28 PST
Comment on attachment 119743 [details]
Only use QtWidgets module if using Qt5, reuse previous test clause

Clearing flags on attachment: 119743

Committed r103164: <http://trac.webkit.org/changeset/103164>
Comment 7 WebKit Review Bot 2011-12-17 19:35:32 PST
All reviewed patches have been landed.  Closing bug.