Bug 74785 - [Qt] fast/canvas/2d.text.draw.fill.maxWidth.gradient.html fails with newer Qt5
Summary: [Qt] fast/canvas/2d.text.draw.fill.maxWidth.gradient.html fails with newer Qt5
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P1 Critical
Assignee: Csaba Osztrogonác
URL:
Keywords: Qt, QtTriaged
Depends on:
Blocks:
 
Reported: 2011-12-17 04:47 PST by Csaba Osztrogonác
Modified: 2012-01-17 06:34 PST (History)
5 users (show)

See Also:


Attachments
Patch (1.49 KB, patch)
2012-01-05 05:03 PST, Simon Hausmann
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Csaba Osztrogonác 2011-12-17 04:47:51 PST
fast/canvas/2d.text.draw.fill.maxWidth.gradient.html started to fail after 
updating Qt5: https://lists.webkit.org/pipermail/webkit-qt/2011-December/002279.html

This test now fails with Qt5-WK1 and Qt5-WK2 too:
--- /home/webkitbuildbot/slaves/release32bit-qt5/buildslave/qt-linux-32-release-qt5/build/layout-test-results/fast/canvas/2d.text.draw.fill.maxWidth.gradient-expected.txt 
+++ /home/webkitbuildbot/slaves/release32bit-qt5/buildslave/qt-linux-32-release-qt5/build/layout-test-results/fast/canvas/2d.text.draw.fill.maxWidth.gradient-actual.txt 
@@ -1,3 +1,3 @@
 On success, there should only be a green rectangle.
 
-TEST PASSED
+TEST FAILED


It might be a Qt bug, I don't know.
Comment 1 Csaba Osztrogonác 2011-12-17 05:47:09 PST
Skipped by http://trac.webkit.org/changeset/103146
Comment 2 Csaba Osztrogonác 2011-12-23 02:03:14 PST
It is P1/critical, because it is a regression.
Comment 3 Simon Hausmann 2012-01-04 04:35:36 PST
Commit d52fd497f60a3c4456994f4f10e9451d611c9ea4 / http://codereview.qt-project.org/#change,11008 is the culprit.
Comment 4 Simon Hausmann 2012-01-04 07:32:10 PST
Upstream issue created https://bugreports.qt.nokia.com/browse/QTBUG-23450
Comment 5 Simon Hausmann 2012-01-05 05:03:14 PST
Created attachment 121263 [details]
Patch
Comment 6 Simon Hausmann 2012-01-05 05:04:00 PST
Ossy, feel free to land this with the next qt5 update :)
Comment 7 Csaba Osztrogonác 2012-01-05 05:23:55 PST
Comment on attachment 121263 [details]
Patch

Thanks for the fix. r=me, I'll land it with Qt5 update.
Comment 8 Rafael Brandao 2012-01-17 06:03:06 PST
Is this issue solved? Can we close it then?
Comment 9 Csaba Osztrogonác 2012-01-17 06:05:07 PST
Comment on attachment 121263 [details]
Patch

Yes, but I'm missed to land the patch. cq+ to land it.
Comment 10 Csaba Osztrogonác 2012-01-17 06:34:17 PST
Committed r105150