From https://bugs.webkit.org/show_bug.cgi?id=74490 Comment #36 From Mark Rowe (bdash) 2011-12-16 20:20:42 PST (-) [reply] The following headers are in WebCore.framework/PrivateHeaders and include CompositeEditCommand.h: ApplyBlockElementCommand.h DeleteSelectionCommand.h MoveSelectionCommand.h ReplaceSelectionCommand.h TypingCommand.h Any and all of these will cause similar build failures if used. ... Comment #40 From Ryosuke Niwa 2011-12-16 20:30:27 PST (-) [reply] Oops, it appears that _insertParagraphSeparatorInQuotedContent is calling TypingCommand::insertParagraphSeparatorInQuotedContent :( I'll have to add CompositeEditCommand.h back to the framework. WebKit layer shouldn't be including any one of these Command files.
Created attachment 139592 [details] Remove the dependency
Created attachment 139593 [details] Removed more symbols from WebCore.exp.in
Enrica, it seems like you've preemptively exported SimplifyMarkupCommand. Could you wrap it in an Editor class' method so that we don't have to directly expose the command?
Comment on attachment 139593 [details] Removed more symbols from WebCore.exp.in Yes! Thank you.
(In reply to comment #4) > (From update of attachment 139593 [details]) > Yes! Thank you. Thanks for the review! Yeah, I'm very happy with removing this dependency. It makes my future refactoring work much easier :)
Comment on attachment 139593 [details] Removed more symbols from WebCore.exp.in Clearing flags on attachment: 139593 Committed r115760: <http://trac.webkit.org/changeset/115760>
All reviewed patches have been landed. Closing bug.