Bug 74764 – Make WebIntentServiceInfo constructor public for testing.

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Greg Billock]

Make WebIntentServiceInfo constructor public for testing.

[Greg Billock]

Created attachment 119694 [details]
Patch

[WebKit Review Bot]

Please wait for approval from [e-mail] before submitting because this patch contains changes to the Chromium public API.

[Darin Fisher (:fishd, Google)]

Comment on attachment 119694 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=119694&action=review

> Source/WebKit/chromium/public/WebIntentServiceInfo.h:44
> +    WebIntentServiceInfo();

please note that using this constructor will break the build if used outside of
webkit.dll.  perhaps you mean to export it?  WEBKIT_EXPORT is the way, or in 
this case, I think it would be better to just inline the constructor as we do
elsewhere.

[WebKit Review Bot]

Comment on attachment 119694 [details]
Patch

Attachment 119694 [details] did not pass chromium-ews (chromium-xvfb):
Output: http://queues.webkit.org/results/10904943

New failing tests:
http/tests/inspector/resource-tree/resource-tree-document-url.html

[Greg Billock]

Created attachment 119873 [details]
Patch

[Greg Billock]

Comment on attachment 119694 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=119694&action=review

>> Source/WebKit/chromium/public/WebIntentServiceInfo.h:44
>> +    WebIntentServiceInfo();
> 
> please note that using this constructor will break the build if used outside of
> webkit.dll.  perhaps you mean to export it?  WEBKIT_EXPORT is the way, or in 
> this case, I think it would be better to just inline the constructor as we do
> elsewhere.

Done.

[WebKit Review Bot]

Comment on attachment 119873 [details]
Patch

Clearing flags on attachment: 119873

Committed r103311: <http://trac.webkit.org/changeset/103311>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.