WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED INVALID
74763
Style bot should complain if someone tries to export an s_info class member by putting it in a .def file
https://bugs.webkit.org/show_bug.cgi?id=74763
Summary
Style bot should complain if someone tries to export an s_info class member b...
Mark Hahnenberg
Reported
2011-12-16 15:51:11 PST
Exporting ClassInfos across DLLs can cause badness if not done the right way (using JS_EXPORTDATA and *not* having it in the symbol export file). The style bot should know the correct way and should smack anybody's hand who tries to do it the incorrect way.
Attachments
Add attachment
proposed patch, testcase, etc.
Adam Roben (:aroben)
Comment 1
2011-12-16 15:51:56 PST
Basically we can just grep all .def files for "s_info" and complain if we find it.
Mark Hahnenberg
Comment 2
2012-10-16 22:16:03 PDT
We don't have .def files any more. Hooray!
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug