Bug 74753 - Add a pretty dumb tile cache to WebTileCacheLayer
Summary: Add a pretty dumb tile cache to WebTileCacheLayer
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Anders Carlsson
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-12-16 14:39 PST by Anders Carlsson
Modified: 2011-12-16 15:05 PST (History)
1 user (show)

See Also:

Attachments
Patch (27.12 KB, patch)
2011-12-16 14:51 PST, Anders Carlsson 		simon.fraser: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Anders Carlsson 2011-12-16 14:39:18 PST 
Add a pretty dumb tile cache to WebTileCacheLayer
Comment 1 Anders Carlsson 2011-12-16 14:51:47 PST 
Created attachment 119677 [details]
Patch
Comment 2 WebKit Review Bot 2011-12-16 14:56:10 PST 
Attachment 119677 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCor..." exit_code: 1

Source/WebCore/platform/graphics/ca/mac/WebTileCacheLayer.h:30:  Code inside a namespace should not be indented.  [whitespace/indent] [4]
Source/WebCore/platform/graphics/ca/mac/WebTileLayer.h:30:  Code inside a namespace should not be indented.  [whitespace/indent] [4]
Total errors found: 2 in 12 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Simon Fraser (smfr) 2011-12-16 14:57:07 PST 
Comment on attachment 119677 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=119677&action=review

> Source/WebCore/platform/graphics/ca/mac/TileCache.h:67
> +    void getTileRangeForRect(const IntRect&, IntPoint& topLeft, IntPoint& bottomRight);
> +
> +    IntSize numTilesForGridSize(const IntSize&);

Can these be const?

> Source/WebCore/platform/graphics/ca/mac/TileCache.h:70
> +    WebTileLayer* tileLayerAtPosition(const IntPoint&);

Make const?

> Source/WebCore/platform/graphics/ca/mac/TileCache.mm:99
> +        CGContextRestoreGState(context);

Tab here?

> Source/WebCore/platform/graphics/ca/mac/WebTileCacheLayer.h:34
> +    OwnPtr<WebCore::TileCache> _tileCache;

Do we still do underscores on Obj-C member vars? Is ugly.
Comment 4 Anders Carlsson 2011-12-16 15:01:38 PST 
(In reply to comment #3)/ca/mac/WebTileCacheLayer.h:34
> > +    OwnPtr<WebCore::TileCache> _tileCache;
> 
> Do we still do underscores on Obj-C member vars? Is ugly.

That is the Objective-C convention, ugly or not :)
Comment 5 Anders Carlsson 2011-12-16 15:05:31 PST 
Committed r103114: <http://trac.webkit.org/changeset/103114>