Bug 74753 – Add a pretty dumb tile cache to WebTileCacheLayer

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Anders Carlsson]

Add a pretty dumb tile cache to WebTileCacheLayer

[Anders Carlsson]

Created attachment 119677 [details]
Patch

[WebKit Review Bot]

Attachment 119677 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCor..." exit_code: 1

Source/WebCore/platform/graphics/ca/mac/WebTileCacheLayer.h:30:  Code inside a namespace should not be indented.  [whitespace/indent] [4]
Source/WebCore/platform/graphics/ca/mac/WebTileLayer.h:30:  Code inside a namespace should not be indented.  [whitespace/indent] [4]
Total errors found: 2 in 12 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Simon Fraser (smfr)]

Comment on attachment 119677 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=119677&action=review

> Source/WebCore/platform/graphics/ca/mac/TileCache.h:67
> +    void getTileRangeForRect(const IntRect&, IntPoint& topLeft, IntPoint& bottomRight);
> +
> +    IntSize numTilesForGridSize(const IntSize&);

Can these be const?

> Source/WebCore/platform/graphics/ca/mac/TileCache.h:70
> +    WebTileLayer* tileLayerAtPosition(const IntPoint&);

Make const?

> Source/WebCore/platform/graphics/ca/mac/TileCache.mm:99
> +        CGContextRestoreGState(context);

Tab here?

> Source/WebCore/platform/graphics/ca/mac/WebTileCacheLayer.h:34
> +    OwnPtr<WebCore::TileCache> _tileCache;

Do we still do underscores on Obj-C member vars? Is ugly.

[Anders Carlsson]

(In reply to comment #3)/ca/mac/WebTileCacheLayer.h:34
> > +    OwnPtr<WebCore::TileCache> _tileCache;
> 
> Do we still do underscores on Obj-C member vars? Is ugly.

That is the Objective-C convention, ugly or not :)

[Anders Carlsson]

Committed r103114: <http://trac.webkit.org/changeset/103114>