After http://trac.webkit.org/changeset/103104, the interface for unapply/reapplying an editing action has been changed from EditCommand to UndoStep. We should rename these methods as well.
Created attachment 119678 [details] cleanup
Comment on attachment 119678 [details] cleanup View in context: https://bugs.webkit.org/attachment.cgi?id=119678&action=review > Source/WebCore/editing/Editor.cpp:892 > - client()->registerCommandForUndo(toCompositeEditCommand(m_lastEditCommand.get())->ensureComposition()); > + client()->registerUndoStep(toCompositeEditCommand(m_lastEditCommand.get())->ensureComposition()); If we do this casting often we should have a lastCommandAsComposite() or similar accessor :)
Comment on attachment 119678 [details] cleanup View in context: https://bugs.webkit.org/attachment.cgi?id=119678&action=review >> Source/WebCore/editing/Editor.cpp:892 >> + client()->registerUndoStep(toCompositeEditCommand(m_lastEditCommand.get())->ensureComposition()); > > If we do this casting often we should have a lastCommandAsComposite() or similar accessor :) Actually, this cast is no longer necessary as m_lastEditCommand's type is now RefPtr<CompositeEditCommand>. Will remove the cast.
Committed r103119: <http://trac.webkit.org/changeset/103119>