RESOLVED WONTFIX 74742
Commit queue should lint Chromium expectations before landing 
https://bugs.webkit.org/show_bug.cgi?id=74742
Summary Commit queue should lint Chromium expectations before landing
Adrienne Walker
Reported 2011-12-16 13:23:12 PST
Earlier today, the commit queue landed r103091, which broke layout tests because of a duplicate expectation: http://build.chromium.org/p/chromium.webkit/builders/Webkit%20Win/builds/10009/steps/webkit_tests/logs/stdio It would be excellent if the commit queue could lint-test-files prior to landing.
Attachments
Add attachment proposed patch, testcase, etc.
Eric Seidel (no email)
Comment 1 2011-12-16 13:56:18 PST
I thought the style-queue already did such linting? Maybe the style-queue was down when that landed?
Tony Chang
Comment 2 2011-12-16 13:57:50 PST
I think style queue does the linting, but the cq+ was given about a week after the patch was r+'ed. The duplicate crept in during that time.
Adam Barth
Comment 3 2011-12-16 14:13:00 PST
I'm happy to review a patch that add this feature, but I'm unlikely to write one myself.
Dirk Pranke
Comment 4 2011-12-16 15:46:39 PST
I've also been thinking that we should and a separate step on the bots to check the expectations (and then make them non-fatal when running the layout_tests); see bug 74762 for that.
Note You need to log in before you can comment on or make changes to this bug.