Bug 74742 - Commit queue should lint Chromium expectations before landing
Summary: Commit queue should lint Chromium expectations before landing
Status: RESOLVED WONTFIX
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-12-16 13:23 PST by Adrienne Walker
Modified: 2013-04-08 11:16 PDT (History)
7 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Adrienne Walker 2011-12-16 13:23:12 PST 
Earlier today, the commit queue landed r103091, which broke layout tests because of a duplicate expectation: http://build.chromium.org/p/chromium.webkit/builders/Webkit%20Win/builds/10009/steps/webkit_tests/logs/stdio

It would be excellent if the commit queue could lint-test-files prior to landing.
Comment 1 Eric Seidel (no email) 2011-12-16 13:56:18 PST 
I thought the style-queue already did such linting?  Maybe the style-queue was down when that landed?
Comment 2 Tony Chang 2011-12-16 13:57:50 PST 
I think style queue does the linting, but the cq+ was given about a week after the patch was r+'ed.  The duplicate crept in during that time.
Comment 3 Adam Barth 2011-12-16 14:13:00 PST 
I'm happy to review a patch that add this feature, but I'm unlikely to write one myself.
Comment 4 Dirk Pranke 2011-12-16 15:46:39 PST 
I've also been thinking that we should and a separate step on the bots to check the expectations (and then make them non-fatal when running the layout_tests); see bug 74762 for that.