Bug 74729 - Convert manual test added in http://trac.webkit.org/changeset/70321 to an automated test
Summary: Convert manual test added in http://trac.webkit.org/changeset/70321 to an aut...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Daniel Bates
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2011-12-16 10:21 PST by Brady Eidson
Modified: 2015-09-08 09:01 PDT (History)
6 users (show)

See Also:


Attachments
Layout test (9.45 KB, patch)
2015-09-02 17:31 PDT, Daniel Bates
jhoneycutt: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Brady Eidson 2011-12-16 10:21:10 PST
Manual test added in http://trac.webkit.org/changeset/70321 can be a layouttest

Using:
    layoutTestController.overridePreference("WebKitUsesPageCachePreferenceKey", 1);

DRT *does* support the page cache.
Comment 1 Radar WebKit Bug Importer 2015-09-02 17:16:51 PDT
<rdar://problem/22550195>
Comment 2 Daniel Bates 2015-09-02 17:31:09 PDT
Created attachment 260456 [details]
Layout test
Comment 3 Jon Honeycutt 2015-09-02 18:09:35 PDT
Comment on attachment 260456 [details]
Layout test

View in context: https://bugs.webkit.org/attachment.cgi?id=260456&action=review

r=me

> LayoutTests/compositing/show-composited-iframe-on-back-button.html:17
> +    // First time the page has been loaded.
> +    testRunner.queueLoad("resources/composited-subframe.html");
> +    testRunner.queueBackNavigation(1);
> +    testRunner.queueForwardNavigation(1);
> +    testRunner.queueBackNavigation(1);

The test says that the bug occurs when navigating to a new page and coming back to this one. Why is it necessary to go forward and back a second time?
Comment 4 Daniel Bates 2015-09-04 18:05:17 PDT
(In reply to comment #3)
> Comment on attachment 260456 [details]
> Layout test
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=260456&action=review
> 
> r=me
> 
> > LayoutTests/compositing/show-composited-iframe-on-back-button.html:17
> > +    // First time the page has been loaded.
> > +    testRunner.queueLoad("resources/composited-subframe.html");
> > +    testRunner.queueBackNavigation(1);
> > +    testRunner.queueForwardNavigation(1);
> > +    testRunner.queueBackNavigation(1);
> 
> The test says that the bug occurs when navigating to a new page and coming
> back to this one. Why is it necessary to go forward and back a second time?

It is not necessary. Will fix before landing.
Comment 5 Daniel Bates 2015-09-08 09:01:58 PDT
Committed r189490: <http://trac.webkit.org/changeset/189490>