Bug 74714 - [chromium] MediaStream API: Fixing memory leak in WebMediaStreamSource
: [chromium] MediaStream API: Fixing memory leak in WebMediaStreamSource
Status: RESOLVED FIXED
: WebKit
WebKit API
: 528+ (Nightly build)
: All All
: P2 Normal
Assigned To:
:
:
:
:
  Show dependency treegraph
 
Reported: 2011-12-16 05:59 PST by
Modified: 2011-12-19 13:02 PST (History)


Attachments
Patch (2.44 KB, patch)
2011-12-16 06:03 PST, Tommy Widenflycht
no flags Review Patch | Details | Formatted Diff | Diff


Note

You need to log in before you can comment on or make changes to this bug.


Description From 2011-12-16 05:59:01 PST
Missed that PassRefPtr does a ref if constructed with a raw pointer.
------- Comment #1 From 2011-12-16 06:03:02 PST -------
Created an attachment (id=119608) [details]
Patch
------- Comment #2 From 2011-12-19 11:16:20 PST -------
(From update of attachment 119608 [details])
Yes, assuming m_private is a RefPtr, the previous code was nonsense. :)  I'm curious who reviewed it! :p
------- Comment #3 From 2011-12-19 13:02:16 PST -------
(From update of attachment 119608 [details])
Clearing flags on attachment: 119608

Committed r103258: <http://trac.webkit.org/changeset/103258>
------- Comment #4 From 2011-12-19 13:02:20 PST -------
All reviewed patches have been landed.  Closing bug.