Bug 74713 - [GTK] Use bit field for bool members of WebKitWindowPropertiesPrivate
Summary: [GTK] Use bit field for bool members of WebKitWindowPropertiesPrivate
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit2 (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC Linux
: P2 Normal
Assignee: Nobody
URL:
Keywords: Gtk
Depends on:
Blocks:
 
Reported: 2011-12-16 05:53 PST by Carlos Garcia Campos
Modified: 2011-12-16 06:46 PST (History)
3 users (show)

See Also:


Attachments
Patch (1.56 KB, patch)
2011-12-16 05:57 PST, Carlos Garcia Campos
gustavo: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Carlos Garcia Campos 2011-12-16 05:53:33 PST
Most of the members are bools, so we can reduce the memory footprint a bit.
Comment 1 Carlos Garcia Campos 2011-12-16 05:57:15 PST
Created attachment 119607 [details]
Patch
Comment 2 WebKit Review Bot 2011-12-16 06:02:53 PST
Thanks for the patch. If this patch contains new public API please make sure it follows the guidelines for new WebKit2 GTK+ API. See http://trac.webkit.org/wiki/WebKitGTK/AddingNewWebKit2API
Comment 3 Gustavo Noronha (kov) 2011-12-16 06:19:20 PST
Comment on attachment 119607 [details]
Patch

It's funny that you need to do this for the boolean type, but from what I read this seems to be indeed correct, so r=me
Comment 4 Carlos Garcia Campos 2011-12-16 06:46:40 PST
Committed r103068: <http://trac.webkit.org/changeset/103068>