RESOLVED FIXED 74711
[GTK] Implement create/ready-to-show/close signals in MiniBrowser 
https://bugs.webkit.org/show_bug.cgi?id=74711
Summary [GTK] Implement create/ready-to-show/close signals in MiniBrowser
Carlos Garcia Campos
Reported 2011-12-16 05:44:30 PST
It allows to open links in new windows, and it handles popups too.
Attachments
Patch (4.24 KB, patch)
2011-12-16 05:47 PST, Carlos Garcia Campos 		pnormand: review+
webkit.review.bot: commit-queue-
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Carlos Garcia Campos
Comment 1 2011-12-16 05:47:21 PST
Created attachment 119606 [details] Patch
WebKit Review Bot
Comment 2 2011-12-16 06:22:26 PST
Comment on attachment 119606 [details] Patch Attachment 119606 [details] did not pass chromium-ews (chromium-xvfb): Output: http://queues.webkit.org/results/10910795 New failing tests: http/tests/inspector/resource-parameters.html http/tests/inspector-enabled/console-clear-arguments-on-frame-remove.html
Carlos Garcia Campos
Comment 3 2011-12-16 06:32:02 PST
(In reply to comment #2) > (From update of attachment 119606 [details]) > Attachment 119606 [details] did not pass chromium-ews (chromium-xvfb): > Output: http://queues.webkit.org/results/10910795 > > New failing tests: > http/tests/inspector/resource-parameters.html > http/tests/inspector-enabled/console-clear-arguments-on-frame-remove.html this looks unrelated to the patch.
Philippe Normand
Comment 4 2012-01-02 03:34:53 PST
Comment on attachment 119606 [details] Patch It looks ok to me, just one concern, what about the estimated-load-progress and title properties notifications in the new window? I think they should be handled like in the parent browser window.
Carlos Garcia Campos
Comment 5 2012-01-02 03:41:46 PST
(In reply to comment #4) > (From update of attachment 119606 [details]) > It looks ok to me, just one concern, what about the estimated-load-progress and title properties notifications in the new window? I think they should be handled like in the parent browser window. It's exactly the same, they are connected in constructed method of the BrowserWindow, or what do you mean?
Philippe Normand
Comment 6 2012-01-02 04:01:44 PST
Comment on attachment 119606 [details] Patch You're right indeed :)
Carlos Garcia Campos
Comment 7 2012-01-02 05:39:41 PST
Committed r103904: <http://trac.webkit.org/changeset/103904>
Note You need to log in before you can comment on or make changes to this bug.