Bug 74702 – [EFL] Remove unused parameter names.

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKit EFL

[Eunmi Lee]

Change 'Evas* eventType' to 'Evas* canvas' and 'Evas_Object* callback' to 'Evas_Object* ewkView' and adjust backslash(\) of macro.

[Eunmi Lee]

Created attachment 119592 [details]
Patch for changing parameter names.

[WebKit Review Bot]

Comment on attachment 119592 [details]
Patch for changing parameter names.

Attachment 119592 [details] did not pass chromium-ews (chromium-xvfb):
Output: http://queues.webkit.org/results/10902676

New failing tests:
media/event-attributes.html

[Raphael Kubo da Costa (:rakuco)]

The patch does two separate things which I'd rather commit separately. As for eventType->canvas, the variable was named by Gyuyoung in one of his coding style patches. Why change it again? Could you guys reach some consensus on it?

[Gyuyoung Kim]

Comment on attachment 119592 [details]
Patch for changing parameter names.

View in context: https://bugs.webkit.org/attachment.cgi?id=119592&action=review

Kubo, I also think Evas is canvas and Evas_Object is view object. Previous my patch was wrong. 
Eunmi, I don't understand why this patch break cr-linux ews. It seems there was something wrong. Could you submit patch again ?

> Source/WebKit/efl/ewk/ewk_view.cpp:244
> +#define EWK_VIEW_SD_GET(ewkView, ptr)                                         \

Why did you add spaces to here ? It looks this is unneeded.

[Eunmi Lee]

(In reply to comment #3)
> The patch does two separate things which I'd rather commit separately. As for eventType->canvas, the variable was named by Gyuyoung in one of his coding style patches. Why change it again? Could you guys reach some consensus on it?

OK, I will separate the patch and upload new patch again which includes only changing parameter names.

[Eunmi Lee]

(In reply to comment #4)
> (From update of attachment 119592 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=119592&action=review
> 
> Kubo, I also think Evas is canvas and Evas_Object is view object. Previous my patch was wrong. 
> Eunmi, I don't understand why this patch break cr-linux ews. It seems there was something wrong. Could you submit patch again ?
> 
> > Source/WebKit/efl/ewk/ewk_view.cpp:244
> > +#define EWK_VIEW_SD_GET(ewkView, ptr)                                         \
> 
> Why did you add spaces to here ? It looks this is unneeded.

Yes, I will submit new patch again.
and I added spaces to line 244, to align with other macro's backslash.

[Eunmi Lee]

Created attachment 119796 [details]
Patch for changing parameter names.

New patch which only includes changing parameter names.

[Gyuyoung Kim]

Comment on attachment 119796 [details]
Patch for changing parameter names.

LGTM.

[KwangHyuk]

LGTM.

[Raphael Kubo da Costa (:rakuco)]

On second thought, given these parameters do not seem to be used in the function bodies, why not just remove them and have

  static void foo(void* data, Evas*, Evas_Object*, void* eventInfo)?

[Eunmi Lee]

(In reply to comment #10)
> On second thought, given these parameters do not seem to be used in the function bodies, why not just remove them and have
> 
>   static void foo(void* data, Evas*, Evas_Object*, void* eventInfo)?

Yes, right. we don't have to maintain unused parameter's name.
Thanks for your comment, I will upload new patch again.

[Eunmi Lee]

Created attachment 119985 [details]
patch for removing unused parameter names.

[Raphael Kubo da Costa (:rakuco)]

Looks OK. You might want to check if -Wunused is being passed to gcc and see if there are other places which can be improved too.

[Eric Seidel (no email)]

Comment on attachment 119985 [details]
patch for removing unused parameter names.

rs=me.

[WebKit Review Bot]

Comment on attachment 119985 [details]
patch for removing unused parameter names.

Rejecting attachment 119985 [details] from commit-queue.

Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 2

Last 500 characters of output:
ngeLog
CONFLICT (content): Merge conflict in Source/WebKit2/ChangeLog
Failed to merge in the changes.
Patch failed at 0001 2011-12-21  Nikolas Zimmermann  <[e-mail]>

When you have resolved this problem run "git rebase --continue".
If you would prefer to skip this patch, instead run "git rebase --skip".
To restore the original branch and stop rebasing run "git rebase --abort".

rebase refs/remotes/origin/master: command returned error: 1

Died at Tools/Scripts/update-webkit line 158.

Full output: http://queues.webkit.org/results/10981111

[Eunmi Lee]

Created attachment 120262 [details]
patch for removing unused parameter names.

rebased patch to fix merge conflict.

[WebKit Review Bot]

Comment on attachment 120262 [details]
patch for removing unused parameter names.

Rejecting attachment 120262 [details] from commit-queue.

New failing tests:
fast/workers/storage/use-same-database-in-page-and-workers.html
Full output: http://queues.webkit.org/results/11000458

[Ryuan Choi]

Comment on attachment 120262 [details]
patch for removing unused parameter names.

resetting cq+.
This patch seems not to make failure.

[WebKit Review Bot]

Comment on attachment 120262 [details]
patch for removing unused parameter names.

Clearing flags on attachment: 120262

Committed r103525: <http://trac.webkit.org/changeset/103525>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.