Bug 74701 – [Chromium] Add UVS support on Windows

• Status: RESOLVED
• Resolution: INVALID
• Component: Platform

[Kenichi Ishibashi]

Add UVS support on Windows.

[Kenichi Ishibashi]

Created attachment 119590 [details]
Patch

[Tony Chang]

This looks OK, but I don't know anything about uniscribe.  Adding Brett for an informal review.

[Kenichi Ishibashi]

Could you take a look, Brett?

[Kenichi Ishibashi]

(In reply to comment #3)
> Could you take a look, Brett?

Should I ask an informal review to other developers?

[Eric Seidel (no email)]

A "LGTM" from brett or Jungshik would be helpful, yes.

[Brett Wilson (Google)]

My question is what the uniscribe helper is doing for you in this patch.

Normally, it manages all this complex state for doing things like measuring and laying out a run. In your case, this one function assumes that the object was created with a two character string, and ignores everything else.

As far as I can tell, the only thing you need from the helper is the cached DC, the rest of the code can just be called directly. Maybe we can add a static function to create & return the cached DC so that your code in SimpleFontData can use it.

[Kenichi Ishibashi]

(In reply to comment #6)
> My question is what the uniscribe helper is doing for you in this patch.
> 
> Normally, it manages all this complex state for doing things like measuring and laying out a run. In your case, this one function assumes that the object was created with a two character string, and ignores everything else.
> 
> As far as I can tell, the only thing you need from the helper is the cached DC, the rest of the code can just be called directly. Maybe we can add a static function to create & return the cached DC so that your code in SimpleFontData can use it.

Thank you for review. You are right. I can implement the function following your suggestion.

In any case, I begin to think the current implementation of supporting UVS isn't good. I should have implemented it by using complex path because UVS requires glyph substitution depending on the context. This way, UVS should be supported without any changes on SimpleFontData and UniscribeHelper. I'll change the implementation soon. I'm sorry to bothering you.

[Kenichi Ishibashi]

Filed a bug entry for using complex path for UVS.

https://bugs.webkit.org/show_bug.cgi?id=75289

Closing this bug as INVALID.