Bug 74692 – invalidateNodeListsCacheAfterAttributeChanged has too many callers

• Status: RESOLVED
• Resolution: FIXED
• Component: DOM

[Ryosuke Niwa]

We shouldn't have to call invalidateNodeListsCacheAfterAttributeChanged in various places in DOM code.

[Ryosuke Niwa]

Created attachment 119581 [details]
cleanup and fixes a bug

[Ryosuke Niwa]

Created attachment 119582 [details]
Fixed if for MICRODATA

[Ryosuke Niwa]

Ping reviewers.

[Sam Weinig]

Comment on attachment 119582 [details]
Fixed if for MICRODATA

View in context: https://bugs.webkit.org/attachment.cgi?id=119582&action=review

> Source/WebCore/dom/Node.cpp:1038
> +    if (attrName != classAttr
> +#if ENABLE(MICRODATA)
> +        && attrName != itemscopeAttr
> +        && attrName != itempropAttr
> +#endif
> +        && attrName != nameAttr)
> +        return;

If this needs to be in sync with something, can we extract this logic into a shared function?

[Ryosuke Niwa]

Comment on attachment 119582 [details]
Fixed if for MICRODATA

View in context: https://bugs.webkit.org/attachment.cgi?id=119582&action=review

Thanks for the review!

>> Source/WebCore/dom/Node.cpp:1038
>> +        return;
> 
> If this needs to be in sync with something, can we extract this logic into a shared function?

It's hard to do at the moment because information is hidden in NodeListsNodeData but it'll be straight-forward once we turn NodeListsNodeData into a per-document cache (which I'm planning to do on the next patch).

[Ryosuke Niwa]

Committed r103116: <http://trac.webkit.org/changeset/103116>