Give PlatformEvents a base class
Created attachment 119561 [details] Patch
Giving the EWS a chance to chew through this one. It touches a lot of platform files :(.
Attachment 119561 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCor..." exit_code: 1 Source/WebCore/platform/PlatformMouseEvent.h:97: Should have a space between // and comment [whitespace/comments] [4] Source/WebCore/platform/PlatformMouseEvent.h:137: The parameter name "button" adds no information, so it should be removed. [readability/parameter_name] [5] Source/WebCore/platform/PlatformMouseEvent.h:137: The parameter name "type" adds no information, so it should be removed. [readability/parameter_name] [5] Source/WebCore/platform/PlatformKeyboardEvent.h:69: Code inside a namespace should not be indented. [whitespace/indent] [4] Source/WebCore/platform/wx/MouseEventWx.cpp:40: An else if statement should be written as an if statement when the prior "if" concludes with a return, break, continue or goto statement. [readability/control_flow] [4] Source/WebKit2/WebProcess/WebPage/WebPage.cpp:1187: A case label should not be indented, but line up with its switch statement. [whitespace/indent] [4] Source/WebCore/dom/KeyboardEvent.cpp:40: A case label should not be indented, but line up with its switch statement. [whitespace/indent] [4] Total errors found: 7 in 85 files If any of these errors are false positives, please file a bug against check-webkit-style.
Created attachment 119562 [details] Patch
Attachment 119562 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/CMakeLists.txt', u'Source/W..." exit_code: 1 Source/WebCore/platform/PlatformMouseEvent.h:97: Should have a space between // and comment [whitespace/comments] [4] Source/WebCore/platform/PlatformMouseEvent.h:137: The parameter name "button" adds no information, so it should be removed. [readability/parameter_name] [5] Source/WebCore/platform/PlatformMouseEvent.h:137: The parameter name "type" adds no information, so it should be removed. [readability/parameter_name] [5] Source/WebKit2/WebProcess/WebPage/WebPage.cpp:1187: A case label should not be indented, but line up with its switch statement. [whitespace/indent] [4] Source/WebCore/platform/PlatformKeyboardEvent.h:69: Code inside a namespace should not be indented. [whitespace/indent] [4] Source/WebCore/dom/KeyboardEvent.cpp:40: A case label should not be indented, but line up with its switch statement. [whitespace/indent] [4] Source/WebCore/platform/wx/MouseEventWx.cpp:40: An else if statement should be written as an if statement when the prior "if" concludes with a return, break, continue or goto statement. [readability/control_flow] [4] Total errors found: 7 in 90 files If any of these errors are false positives, please file a bug against check-webkit-style.
Comment on attachment 119562 [details] Patch Attachment 119562 [details] did not pass chromium-ews (chromium-xvfb): Output: http://queues.webkit.org/results/10895582
Created attachment 119569 [details] Patch
Attachment 119569 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/CMakeLists.txt', u'Source/W..." exit_code: 1 Source/WebCore/platform/PlatformMouseEvent.h:97: Should have a space between // and comment [whitespace/comments] [4] Source/WebCore/platform/PlatformMouseEvent.h:137: The parameter name "button" adds no information, so it should be removed. [readability/parameter_name] [5] Source/WebCore/platform/PlatformMouseEvent.h:137: The parameter name "type" adds no information, so it should be removed. [readability/parameter_name] [5] Source/WebKit2/WebProcess/WebPage/WebPage.cpp:1187: A case label should not be indented, but line up with its switch statement. [whitespace/indent] [4] Source/WebCore/platform/PlatformKeyboardEvent.h:69: Code inside a namespace should not be indented. [whitespace/indent] [4] Source/WebCore/dom/KeyboardEvent.cpp:40: A case label should not be indented, but line up with its switch statement. [whitespace/indent] [4] Source/WebCore/platform/wx/MouseEventWx.cpp:40: An else if statement should be written as an if statement when the prior "if" concludes with a return, break, continue or goto statement. [readability/control_flow] [4] Total errors found: 7 in 90 files If any of these errors are false positives, please file a bug against check-webkit-style.
Created attachment 119571 [details] Patch
Attachment 119571 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/CMakeLists.txt', u'Source/W..." exit_code: 1 Source/WebCore/platform/PlatformMouseEvent.h:97: Should have a space between // and comment [whitespace/comments] [4] Source/WebCore/platform/PlatformMouseEvent.h:137: The parameter name "button" adds no information, so it should be removed. [readability/parameter_name] [5] Source/WebCore/platform/PlatformMouseEvent.h:137: The parameter name "type" adds no information, so it should be removed. [readability/parameter_name] [5] Source/WebKit2/WebProcess/WebPage/WebPage.cpp:1187: A case label should not be indented, but line up with its switch statement. [whitespace/indent] [4] Source/WebCore/platform/PlatformKeyboardEvent.h:69: Code inside a namespace should not be indented. [whitespace/indent] [4] Source/WebCore/dom/KeyboardEvent.cpp:40: A case label should not be indented, but line up with its switch statement. [whitespace/indent] [4] Source/WebCore/platform/wx/MouseEventWx.cpp:40: An else if statement should be written as an if statement when the prior "if" concludes with a return, break, continue or goto statement. [readability/control_flow] [4] Total errors found: 7 in 90 files If any of these errors are false positives, please file a bug against check-webkit-style.
Comment on attachment 119571 [details] Patch Attachment 119571 [details] did not pass chromium-ews (chromium-xvfb): Output: http://queues.webkit.org/results/10914573
Comment on attachment 119571 [details] Patch Attachment 119571 [details] did not pass qt-ews (qt): Output: http://queues.webkit.org/results/10900593
Created attachment 119626 [details] Patch
Attachment 119626 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/CMakeLists.txt', u'Source/W..." exit_code: 1 Source/WebCore/platform/PlatformMouseEvent.h:97: Should have a space between // and comment [whitespace/comments] [4] Source/WebCore/platform/PlatformMouseEvent.h:137: The parameter name "button" adds no information, so it should be removed. [readability/parameter_name] [5] Source/WebCore/platform/PlatformMouseEvent.h:137: The parameter name "type" adds no information, so it should be removed. [readability/parameter_name] [5] Source/WebKit2/WebProcess/WebPage/WebPage.cpp:1187: A case label should not be indented, but line up with its switch statement. [whitespace/indent] [4] Source/WebCore/platform/PlatformKeyboardEvent.h:69: Code inside a namespace should not be indented. [whitespace/indent] [4] Source/WebCore/dom/KeyboardEvent.cpp:40: A case label should not be indented, but line up with its switch statement. [whitespace/indent] [4] Source/WebCore/platform/wx/MouseEventWx.cpp:40: An else if statement should be written as an if statement when the prior "if" concludes with a return, break, continue or goto statement. [readability/control_flow] [4] Total errors found: 7 in 90 files If any of these errors are false positives, please file a bug against check-webkit-style.
Comment on attachment 119626 [details] Patch Attachment 119626 [details] did not pass qt-ews (qt): Output: http://queues.webkit.org/results/10904775
Comment on attachment 119626 [details] Patch Attachment 119626 [details] did not pass chromium-ews (chromium-xvfb): Output: http://queues.webkit.org/results/10904784
Created attachment 119632 [details] Patch
Attachment 119632 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/CMakeLists.txt', u'Source/W..." exit_code: 1 Source/WebCore/platform/PlatformMouseEvent.h:97: Should have a space between // and comment [whitespace/comments] [4] Source/WebCore/platform/PlatformMouseEvent.h:137: The parameter name "button" adds no information, so it should be removed. [readability/parameter_name] [5] Source/WebCore/platform/PlatformMouseEvent.h:137: The parameter name "type" adds no information, so it should be removed. [readability/parameter_name] [5] Source/WebKit2/WebProcess/WebPage/WebPage.cpp:1187: A case label should not be indented, but line up with its switch statement. [whitespace/indent] [4] Source/WebCore/platform/PlatformKeyboardEvent.h:69: Code inside a namespace should not be indented. [whitespace/indent] [4] Source/WebCore/dom/KeyboardEvent.cpp:40: A case label should not be indented, but line up with its switch statement. [whitespace/indent] [4] Source/WebCore/platform/wx/MouseEventWx.cpp:40: An else if statement should be written as an if statement when the prior "if" concludes with a return, break, continue or goto statement. [readability/control_flow] [4] Total errors found: 7 in 90 files If any of these errors are false positives, please file a bug against check-webkit-style.
Created attachment 119633 [details] Patch
Attachment 119633 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/CMakeLists.txt', u'Source/W..." exit_code: 1 Source/WebCore/platform/PlatformMouseEvent.h:97: Should have a space between // and comment [whitespace/comments] [4] Source/WebCore/platform/PlatformMouseEvent.h:137: The parameter name "button" adds no information, so it should be removed. [readability/parameter_name] [5] Source/WebCore/platform/PlatformMouseEvent.h:137: The parameter name "type" adds no information, so it should be removed. [readability/parameter_name] [5] Source/WebKit2/WebProcess/WebPage/WebPage.cpp:1187: A case label should not be indented, but line up with its switch statement. [whitespace/indent] [4] Source/WebCore/platform/PlatformKeyboardEvent.h:69: Code inside a namespace should not be indented. [whitespace/indent] [4] Source/WebCore/dom/KeyboardEvent.cpp:40: A case label should not be indented, but line up with its switch statement. [whitespace/indent] [4] Source/WebCore/platform/wx/MouseEventWx.cpp:40: An else if statement should be written as an if statement when the prior "if" concludes with a return, break, continue or goto statement. [readability/control_flow] [4] Total errors found: 7 in 91 files If any of these errors are false positives, please file a bug against check-webkit-style.
Created attachment 119656 [details] Patch
Attachment 119656 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/CMakeLists.txt', u'Source/W..." exit_code: 1 Source/WebKit2/WebProcess/WebPage/WebPage.cpp:1187: A case label should not be indented, but line up with its switch statement. [whitespace/indent] [4] Source/WebCore/platform/PlatformKeyboardEvent.h:69: Code inside a namespace should not be indented. [whitespace/indent] [4] Source/WebCore/dom/KeyboardEvent.cpp:40: A case label should not be indented, but line up with its switch statement. [whitespace/indent] [4] Total errors found: 3 in 91 files If any of these errors are false positives, please file a bug against check-webkit-style.
Comment on attachment 119656 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=119656&action=review > Source/WebCore/platform/PlatformEvent.h:112 > + You should add a protected destructor here as well, that way people won't inadvertly delete a platform event. The destructor doesn't need to be virtual.
Committed r103112: <http://trac.webkit.org/changeset/103112>