Bug 74675 - Add support for accelerated compositing to the tiled Core Animation drawing area
Summary: Add support for accelerated compositing to the tiled Core Animation drawing area
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Anders Carlsson
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-12-15 18:07 PST by Anders Carlsson
Modified: 2011-12-15 18:32 PST (History)
1 user (show)

See Also:


Attachments
Patch (7.70 KB, patch)
2011-12-15 18:11 PST, Anders Carlsson
kling: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Anders Carlsson 2011-12-15 18:07:45 PST
Add support for accelerated compositing to the tiled Core Animation drawing area
Comment 1 Anders Carlsson 2011-12-15 18:11:38 PST
Created attachment 119534 [details]
Patch
Comment 2 Andreas Kling 2011-12-15 18:29:29 PST
Comment on attachment 119534 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=119534&action=review

> Source/WebKit2/WebProcess/WebPage/mac/TiledCoreAnimationDrawingArea.mm:38
> +#import <WebCore/ScrollingCoordinator.h>

Is this one actually needed?

> Source/WebKit2/WebProcess/WebPage/mac/TiledCoreAnimationDrawingArea.mm:112
> +    // This gets called outside of the normal event loop so wrap in an autorelease pool

Mission period at the end, OMG.
Comment 3 Andreas Kling 2011-12-15 18:30:07 PST
(In reply to comment #2)
> (From update of attachment 119534 [details])
> > Source/WebKit2/WebProcess/WebPage/mac/TiledCoreAnimationDrawingArea.mm:112
> > +    // This gets called outside of the normal event loop so wrap in an autorelease pool
> 
> Mission period at the end, OMG.

Missing speling skils in self.
Comment 4 Anders Carlsson 2011-12-15 18:32:17 PST
Committed r103010: <http://trac.webkit.org/changeset/103010>