Bug 74661 – Web Inspector: CodeGeneratorInspector.py: use generated types in method parameters

• Status: RESOLVED
• Resolution: FIXED
• Component: Web Inspector (Deprecated)

[Peter Rybin]

Re-implement CodeGeneratorInspector.py to set generated type to method parameters instead of generic InspectorObject.
Do it in annotation mode (i.e. in comments) so that client code has time to prepare.

[Peter Rybin]

Created attachment 119514 [details]
Patch

[Peter Rybin]

Created attachment 119516 [details]
Patch

[Peter Rybin]

Created attachment 119661 [details]
Sample of InspectorFrontend.h with new types annotated in comments for events.

[Ilya Tikhonovsky]

Comment on attachment 119516 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=119516&action=review

> Source/WebCore/inspector/CodeGeneratorInspector.py:665
> +                        output.append("        };\n\n")

wrong indent.

> Source/WebCore/inspector/CodeGeneratorInspector.py:1510
> +                parameter_list.append("/*%s*/ %s %s" % (param_type_binding.get_in_c_type_text(json_optional), c_type.get_text(), parameter_name))

I'd like to see the suggested types in the comment section only if they differ from the current one.

[Peter Rybin]

(In reply to comment #4)
> (From update of attachment 119516 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=119516&action=review
> 
> > Source/WebCore/inspector/CodeGeneratorInspector.py:665
> > +                        output.append("        };\n\n")
> 
> wrong indent.

Done

> 
> > Source/WebCore/inspector/CodeGeneratorInspector.py:1510
> > +                parameter_list.append("/*%s*/ %s %s" % (param_type_binding.get_in_c_type_text(json_optional), c_type.get_text(), parameter_name))
> 
> I'd like to see the suggested types in the comment section only if they differ from the current one.

Done

[Peter Rybin]

Created attachment 119727 [details]
Patch

[Peter Rybin]

Created attachment 119728 [details]
Sample of InspectorFrontend.h with new types annotated in comments for events.

[Ilya Tikhonovsky]

Comment on attachment 119727 [details]
Patch

lgtm

[Ilya Tikhonovsky]

Comment on attachment 119727 [details]
Patch

Clearing flags on attachment: 119727

Committed r103173: <http://trac.webkit.org/changeset/103173>

[Ilya Tikhonovsky]

All reviewed patches have been landed.  Closing bug.