WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
74656
[Chromium] new-run-webkit-tests attempts to compare images for fast/filesystem/workers/file-writer-gc-blob.html
https://bugs.webkit.org/show_bug.cgi?id=74656
Summary
[Chromium] new-run-webkit-tests attempts to compare images for fast/filesyste...
Dmitry Lomov
Reported
2011-12-15 15:40:51 PST
fast/filesystem/workers/file-writer-gc-blob.html and fast/filesystem/workers/file-writer-write-overlapped.html are affected
Attachments
Add attachment
proposed patch, testcase, etc.
Dirk Pranke
Comment 1
2011-12-15 15:56:31 PST
I have reproduced this and am looking at it now.
Dirk Pranke
Comment 2
2011-12-15 16:01:31 PST
Okay, it looks like when those tests were added to the repository, Eric added the expected results as fast/filesystem/workers/file-writer-gc-blob-expected.html instead of fast/filesystem/workers/file-writer-gc-blob-expected.txt. As a result, new-run-webkit-tests thinks this is a reftest and runs both of them and attempts to compare the output. But, there is no output when we run things as dumpAsText(), so we compare "no png" to "the text rendered as a png". Looks like this will happen for fast/filesystem/workers/file-writer-write-overlapped-expected.html as well. I think you just want to rename the -expected.html files.
Dirk Pranke
Comment 3
2011-12-15 16:03:22 PST
rniwa, hayato - interesting failure to note here ... we're treating things as reftests that aren't reftests.
Eric U.
Comment 4
2011-12-15 16:03:47 PST
Ug--sorry about that. Will fix.
Dirk Pranke
Comment 5
2011-12-15 16:04:18 PST
we should probably file a separate bug to make this failure case distinct from a regular image failure somehow.
Hayato Ito
Comment 6
2011-12-21 18:27:22 PST
I agree. Let me think how we should detect and report these type of errors. (In reply to
comment #5
)
> we should probably file a separate bug to make this failure case distinct from a regular image failure somehow.
Eric U.
Comment 7
2012-03-20 15:06:33 PDT
Dmitry fixed this months ago.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug