Bug 74639 – Add ScrollingCoordinator class and ENABLE_THREADED_SCROLLING define

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Anders Carlsson]

Add ScrollingCoordinator class and ENABLE_THREADED_SCROLLING define

[Anders Carlsson]

Created attachment 119483 [details]
Patch

[Andreas Kling]

Comment on attachment 119483 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=119483&action=review

> Source/JavaScriptCore/wtf/Platform.h:1067
> +#if PLATFORM(MAC) && !defined(BUILDING_ON_LEOPARD) && !defined(BUILDING_ON_SNOW_LEOPARD) && !defined(BUILDING_ON_LION)
> +#define ENABLE_THREADED_SCROLLING 1
> +#endif

Even with the very restrictive conditionals, I think an e-mail to webkit-dev is in order before landing a new ENABLE() flag.

[Anders Carlsson]

Committed r102975: <http://trac.webkit.org/changeset/102975>

[David Levin]

Comment on attachment 119483 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=119483&action=review

> Source/WebCore/page/Page.cpp:91
> +#endif

I thought for include's we just put them in the normal include flow and let the ifdef in the header be enough.

> Source/WebCore/page/ScrollingCoordinator.h:33
> +#include <wtf/Threading.h>

Nothing from Threading.h is used yet but I guess that is in another patch soon.

> Source/WebCore/page/ScrollingCoordinator.h:38
> +class PlatformWheelEvent;

Not used yet "PlatformWheelEvent" but I guess it is coming.

[James Robinson]

(In reply to comment #2)
> (From update of attachment 119483 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=119483&action=review
> 
> > Source/JavaScriptCore/wtf/Platform.h:1067
> > +#if PLATFORM(MAC) && !defined(BUILDING_ON_LEOPARD) && !defined(BUILDING_ON_SNOW_LEOPARD) && !defined(BUILDING_ON_LION)
> > +#define ENABLE_THREADED_SCROLLING 1
> > +#endif
> 
> Even with the very restrictive conditionals, I think an e-mail to webkit-dev is in order before landing a new ENABLE() flag.

Any particular reason this email didn't happen?