Bug 74613 – [qt][wk2] Viewport info panel shows wrong current scale

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKit2

[Michael Brüning]

The viewport info panel in the qt MiniBrowser shows the item scale, not the css scale.

[Michael Brüning]

Created attachment 119438 [details]
Proposed patch.

Current scale is now calculated by dividing the item scale by the devicePixelRatio.

[Michael Brüning]

Created attachment 119440 [details]
Update patch.

Updated patch so it is limited to qwebviewport.cpp and qwebviewport_p.h and corrected whitespace error introduced in previous version's ChangeLog.

[Kenneth Rohde Christiansen]

Comment on attachment 119440 [details]
Update patch.

View in context: https://bugs.webkit.org/attachment.cgi?id=119440&action=review

> Source/WebKit2/UIProcess/API/qt/qwebviewportinfo.cpp:49
> +    return m_webViewPrivate->pageView->scale() / m_webViewPrivate->interactionEngine->constraints().devicePixelRatio;

There are methods for doing this in the interaction engine class. Could you see if it is possible to use them?

[Michael Brüning]

> There are methods for doing this in the interaction engine class. Could you see if it is possible to use them?

Will check if that's possible...

[Michael Brüning]

Created attachment 119587 [details]
Updated patch.

Added method currentCSSScale to QtViewportInteractionEngine and changed QWebViewportInfo to use this to return the scale.

Also changed one place in QtViewportInteractionEngine to use this new method.

[WebKit Review Bot]

Comment on attachment 119587 [details]
Updated patch.

Clearing flags on attachment: 119587

Committed r103054: <http://trac.webkit.org/changeset/103054>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.