RESOLVED FIXED 74612
Each worker separately logs its complaint about the directory I am in 
https://bugs.webkit.org/show_bug.cgi?id=74612
Summary Each worker separately logs its complaint about the directory I am in
Darin Adler
Reported 2011-12-15 09:01:23 PST
When I run tests, I get this: The current directory (/Users/darin/Safari) is not a WebKit checkout, using /Users/darin/Safari/OpenSource Starting 8 workers ...The current directory (/Users/darin/Safari) is not a WebKit checkout, using /Users/darin/Safari/OpenSource The current directory (/Users/darin/Safari) is not a WebKit checkout, using /Users/darin/Safari/OpenSource The current directory (/Users/darin/Safari) is not a WebKit checkout, using /Users/darin/Safari/OpenSource The current directory (/Users/darin/Safari) is not a WebKit checkout, using /Users/darin/Safari/OpenSource The current directory (/Users/darin/Safari) is not a WebKit checkout, using /Users/darin/Safari/OpenSource The current directory (/Users/darin/Safari) is not a WebKit checkout, using /Users/darin/Safari/OpenSource The current directory (/Users/darin/Safari) is not a WebKit checkout, using /Users/darin/Safari/OpenSource The current directory (/Users/darin/Safari) is not a WebKit checkout, using /Users/darin/Safari/OpenSource I don’t need to see that log message 9 times. In fact, I’d prefer not to see it even once.
Attachments
Add attachment proposed patch, testcase, etc.
Eric Seidel (no email)
Comment 1 2011-12-15 10:06:52 PST
Sure thing. Easy to fix. Just an unintented consequence of re-using single-process code in our new multi-process architecture. :)
Eric Seidel (no email)
Comment 2 2011-12-15 10:15:51 PST
You'll likely want this when running webkit-patch apply-from-bug outside of a webkit directory, but not when running new-run-webkit-tests. Or at least not 7 times. :) Then again, it's possible it's not even useful when running webkit-patch from outside of a webkit directory.
Dirk Pranke
Comment 3 2011-12-15 12:38:18 PST
I agree w/ Darin; new-run-webkit-tests shouldn't be complaining about this at all by default, and it should definitely only be complaining once. Can we change scm/detection.py to provide a am_inside_the_checkout() function so that webkit-patch can call this separately and log the warning?
Eric Seidel (no email)
Comment 4 2011-12-15 12:43:19 PST
(In reply to comment #3) > I agree w/ Darin; new-run-webkit-tests shouldn't be complaining about this at all by default, and it should definitely only be complaining once. Can we change scm/detection.py to provide a am_inside_the_checkout() function so that webkit-patch can call this separately and log the warning? Sounds like a good approach. I agree. webkit-patch should be specifically opting into this warning, instead of all SCM clients causing it.
Dirk Pranke
Comment 5 2012-06-19 21:10:01 PDT
I think this was fixed in r120646. Please let me know if you're still seeing an issue.
Note You need to log in before you can comment on or make changes to this bug.