Bug 74580 – Separate box alignment and box pack values into separate enums.

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Luke Macpherson]

Separate box alignment and box pack values into separate enums.

[Luke Macpherson]

Created attachment 119362 [details]
Patch

[WebKit Review Bot]

Comment on attachment 119362 [details]
Patch

Clearing flags on attachment: 119362

Committed r102989: <http://trac.webkit.org/changeset/102989>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.

[Kenneth Russell]

After r102989 there are crashes of many layout tests in debug mode reporting "SHOULD NEVER BE REACHED". A representative failure:

http://build.chromium.org/p/chromium.webkit/builders/Webkit%20Linux%20%28dbg%29/builds/1343

Click the "stdio" link and search for the above text.

Going to roll out the patch after discussion with macpherson.

[Kenneth Russell]

Reverted r102989 for reason:

Caused SHOULD NOT BE REACHED assertions in debug builds.

Committed r102999: <http://trac.webkit.org/changeset/102999>

[Luke Macpherson]

Spotted the problem - CSSPropertyWebkitBoxPack was missing return after macro, calling fall-through onto CSSPropertyWebkitBoxFlex case. Will update patch in a moment.

[Luke Macpherson]

Created attachment 119537 [details]
Patch for landing

[WebKit Review Bot]

Comment on attachment 119537 [details]
Patch for landing

Rejecting attachment 119537 [details] from commit-queue.

Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 1

ERROR: /mnt/git/webkit-commit-queue/Source/WebCore/ChangeLog neither lists a valid reviewer nor contains the string "Unreviewed" or "Rubber stamp" (case insensitive).

Full output: http://queues.webkit.org/results/10902567

[WebKit Review Bot]

Comment on attachment 119537 [details]
Patch for landing

Rejecting attachment 119537 [details] from commit-queue.

Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 2

Last 500 characters of output:
webkit-commit-queue/Source/WebKit/chromium/webkit --revision 114686 --non-interactive --force --accept theirs-conflict --ignore-externals' in '/mnt/git/webkit-commit-queue/Source/WebKit/chromium'
47>At revision 114686.

________ running '/usr/bin/python tools/clang/scripts/update.py --mac-only' in '/mnt/git/webkit-commit-queue/Source/WebKit/chromium'

________ running '/usr/bin/python gyp_webkit' in '/mnt/git/webkit-commit-queue/Source/WebKit/chromium'
Updating webkit projects from gyp files...

Full output: http://queues.webkit.org/results/10932396

[Luke Macpherson]

Comment on attachment 119537 [details]
Patch for landing

Clearing flags on attachment: 119537

Committed r103209: <http://trac.webkit.org/changeset/103209>

[Luke Macpherson]

All reviewed patches have been landed.  Closing bug.