Bug 74552 - binding a member function should ref/deref the object pointer if needed
Summary: binding a member function should ref/deref the object pointer if needed
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Anders Carlsson
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-12-14 16:02 PST by Anders Carlsson
Modified: 2011-12-14 17:37 PST (History)
2 users (show)

See Also:


Attachments
Patch (6.84 KB, patch)
2011-12-14 16:07 PST, Anders Carlsson
sam: review+
webkit.review.bot: commit-queue-
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Anders Carlsson 2011-12-14 16:02:22 PST
binding a member function should ref/deref the object pointer if needed
Comment 1 Anders Carlsson 2011-12-14 16:07:39 PST
Created attachment 119314 [details]
Patch
Comment 2 WebKit Review Bot 2011-12-14 16:09:24 PST
Attachment 119314 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/JavaScriptCore/ChangeLog', u'Source..." exit_code: 1

Tools/TestWebKitAPI/Tests/WTF/Functional.cpp:144:  Extra space before ( in function call  [whitespace/parens] [4]
Tools/TestWebKitAPI/Tests/WTF/Functional.cpp:147:  Extra space before ( in function call  [whitespace/parens] [4]
Total errors found: 2 in 4 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 WebKit Review Bot 2011-12-14 16:38:48 PST
Comment on attachment 119314 [details]
Patch

Attachment 119314 [details] did not pass chromium-ews (chromium-xvfb):
Output: http://queues.webkit.org/results/10900013
Comment 4 Sam Weinig 2011-12-14 17:28:22 PST
Comment on attachment 119314 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=119314&action=review

> Source/JavaScriptCore/wtf/Functional.h:160
> +template<typename T, bool> struct RefAndDeref {

You should note what the bool means here.
Comment 5 Anders Carlsson 2011-12-14 17:37:58 PST
Committed r102857: <http://trac.webkit.org/changeset/102857>