RESOLVED FIXED 74552
binding a member function should ref/deref the object pointer if needed 
https://bugs.webkit.org/show_bug.cgi?id=74552
Summary binding a member function should ref/deref the object pointer if needed
Anders Carlsson
Reported 2011-12-14 16:02:22 PST
binding a member function should ref/deref the object pointer if needed
Attachments
Patch (6.84 KB, patch)
2011-12-14 16:07 PST, Anders Carlsson 		sam: review+
webkit.review.bot: commit-queue-
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Anders Carlsson
Comment 1 2011-12-14 16:07:39 PST
Created attachment 119314 [details] Patch
WebKit Review Bot
Comment 2 2011-12-14 16:09:24 PST
Attachment 119314 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/JavaScriptCore/ChangeLog', u'Source..." exit_code: 1 Tools/TestWebKitAPI/Tests/WTF/Functional.cpp:144: Extra space before ( in function call [whitespace/parens] [4] Tools/TestWebKitAPI/Tests/WTF/Functional.cpp:147: Extra space before ( in function call [whitespace/parens] [4] Total errors found: 2 in 4 files If any of these errors are false positives, please file a bug against check-webkit-style.
WebKit Review Bot
Comment 3 2011-12-14 16:38:48 PST
Comment on attachment 119314 [details] Patch Attachment 119314 [details] did not pass chromium-ews (chromium-xvfb): Output: http://queues.webkit.org/results/10900013
Sam Weinig
Comment 4 2011-12-14 17:28:22 PST
Comment on attachment 119314 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=119314&action=review > Source/JavaScriptCore/wtf/Functional.h:160 > +template<typename T, bool> struct RefAndDeref { You should note what the bool means here.
Anders Carlsson
Comment 5 2011-12-14 17:37:58 PST
Committed r102857: <http://trac.webkit.org/changeset/102857>
Note You need to log in before you can comment on or make changes to this bug.