Bug 74549 - Web Inspector: Switch to type-safe JSON ConsoleMessage.cpp, InspectorDOMAgent.cpp, InspectorDebuggerAgent.cpp, ScriptCallFrame.cpp
Summary: Web Inspector: Switch to type-safe JSON ConsoleMessage.cpp, InspectorDOMAgent...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (Deprecated) (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on: 72861
Blocks:
  Show dependency tree / graph
 
Reported: 2011-12-14 15:41 PST by Peter Rybin
Modified: 2011-12-18 07:06 PST (History)
13 users (show)

See Also:

Attachments
Patch (11.15 KB, patch)
2011-12-14 15:50 PST, Peter Rybin 		no flags Details | Formatted Diff | Diff
Patch (13.28 KB, patch)
2011-12-15 11:42 PST, Peter Rybin 		no flags Details | Formatted Diff | Diff
Patch (14.81 KB, patch)
2011-12-15 14:11 PST, Peter Rybin 		no flags Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Peter Rybin 2011-12-14 15:41:56 PST 
Switch some core agents to newly created type-safe JSON TypeBuilder API.
Comment 1 Peter Rybin 2011-12-14 15:50:17 PST 
Created attachment 119311 [details]
Patch
Comment 2 WebKit Review Bot 2011-12-14 16:50:12 PST 
Comment on attachment 119311 [details]
Patch

Attachment 119311 [details] did not pass chromium-ews (chromium-xvfb):
Output: http://queues.webkit.org/results/10910015

New failing tests:
inspector/protocol/console-agent.html
Comment 3 Pavel Feldman 2011-12-15 00:18:06 PST 
Comment on attachment 119311 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=119311&action=review

Great job!

> Source/WebCore/inspector/ScriptCallFrame.cpp:67
> +            String::number(m_lineNumber))

Please do a drive-by fix to the protocol itself instead of this workaround. You can also fix the Inspector-0.1.json in this case - it is clearly a typo.
Comment 4 Peter Rybin 2011-12-15 11:42:12 PST 
Created attachment 119473 [details]
Patch
Comment 5 WebKit Review Bot 2011-12-15 12:43:27 PST 
Comment on attachment 119473 [details]
Patch

Attachment 119473 [details] did not pass chromium-ews (chromium-xvfb):
Output: http://queues.webkit.org/results/10915004

New failing tests:
inspector/protocol/console-agent.html
Comment 6 Peter Rybin 2011-12-15 14:11:28 PST 
Created attachment 119501 [details]
Patch
Comment 7 Ilya Tikhonovsky 2011-12-18 07:06:30 PST 
Comment on attachment 119501 [details]
Patch

Clearing flags on attachment: 119501

Committed r103174: <http://trac.webkit.org/changeset/103174>
Comment 8 Ilya Tikhonovsky 2011-12-18 07:06:38 PST 
All reviewed patches have been landed.  Closing bug.