Bug 74543 - WebCore build exceeds address space on 32-bit Windows builders
Summary: WebCore build exceeds address space on 32-bit Windows builders
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: CSS (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Lucas Forschler
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-12-14 14:48 PST by Lucas Forschler
Modified: 2011-12-14 22:57 PST (History)
4 users (show)

See Also:


Attachments
Combine CSS*.cpp files into CSSAllInOne.cpp (84.26 KB, patch)
2011-12-14 15:06 PST, Lucas Forschler
sfalken: review+
webkit.review.bot: commit-queue-
Details | Formatted Diff | Diff
Update the CSS*.cpp files to CSSAllInOne.cpp (84.24 KB, patch)
2011-12-14 21:44 PST, Lucas Forschler
no flags Details | Formatted Diff | Diff
Update CSS*.cpp files to a CSSAllInOne.cpp file (84.26 KB, patch)
2011-12-14 21:54 PST, Lucas Forschler
no flags Details | Formatted Diff | Diff
Combine CSS*.cpp into CSSAllInOne.cpp (84.26 KB, patch)
2011-12-14 22:04 PST, Lucas Forschler
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Lucas Forschler 2011-12-14 14:48:26 PST
Linking on windows uses up too much memory and fails.  In the past we have combined features into "AllInOne.cpp" files to fix this.

CSS would be a good one to apply this method.
Comment 1 Lucas Forschler 2011-12-14 15:06:06 PST
Created attachment 119306 [details]
Combine CSS*.cpp files into CSSAllInOne.cpp
Comment 2 WebKit Review Bot 2011-12-14 18:09:39 PST
Comment on attachment 119306 [details]
Combine CSS*.cpp files into CSSAllInOne.cpp

Rejecting attachment 119306 [details] from commit-queue.

Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 2

Last 500 characters of output:
ded at 71665 (offset 16 lines).
Hunk #77 succeeded at 71685 (offset 16 lines).
Hunk #78 succeeded at 71709 (offset 16 lines).
Hunk #79 succeeded at 71781 (offset 16 lines).
Hunk #80 succeeded at 71849 (offset 16 lines).
1 out of 80 hunks FAILED -- saving rejects to file Source/WebCore/WebCore.vcproj/WebCore.vcproj.rej
patching file Source/WebCore/css/CSSAllInOne.cpp

Failed to run "[u'/mnt/git/webkit-commit-queue/Tools/Scripts/svn-apply', u'--reviewer', u'Steve Falkenburg', u'-..." exit_code: 1

Full output: http://queues.webkit.org/results/10903041
Comment 3 Lucas Forschler 2011-12-14 21:44:22 PST
Created attachment 119372 [details]
Update the CSS*.cpp files to CSSAllInOne.cpp

the last patch failed to commit, trying again.
Comment 4 WebKit Review Bot 2011-12-14 21:46:08 PST
Attachment 119372 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCor..." exit_code: 1

Source/WebCore/css/CSSAllInOne.cpp:26:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
Source/WebCore/ChangeLog:4:  Line contains tab character.  [whitespace/tab] [5]
Source/WebCore/ChangeLog:5:  Line contains tab character.  [whitespace/tab] [5]
Source/WebCore/ChangeLog:6:  Line contains tab character.  [whitespace/tab] [5]
Source/WebCore/ChangeLog:7:  Line contains tab character.  [whitespace/tab] [5]
Source/WebCore/ChangeLog:8:  Line contains tab character.  [whitespace/tab] [5]
Total errors found: 6 in 3 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 5 Lucas Forschler 2011-12-14 21:54:55 PST
Created attachment 119374 [details]
Update CSS*.cpp files to a CSSAllInOne.cpp file

Fix whitespace/tab issue.
Comment 6 WebKit Review Bot 2011-12-14 21:58:37 PST
Attachment 119374 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCor..." exit_code: 1

Source/WebCore/ChangeLog:8:  Line contains tab character.  [whitespace/tab] [5]
Total errors found: 1 in 3 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 7 Lucas Forschler 2011-12-14 22:04:32 PST
Created attachment 119375 [details]
Combine CSS*.cpp into CSSAllInOne.cpp

evidently, notepad++ on windows doesn't convert existing tabs to spaces on save after a preference change.
Trying again.
Comment 8 WebKit Review Bot 2011-12-14 22:57:46 PST
Comment on attachment 119375 [details]
Combine CSS*.cpp into CSSAllInOne.cpp

Clearing flags on attachment: 119375

Committed r102895: <http://trac.webkit.org/changeset/102895>
Comment 9 WebKit Review Bot 2011-12-14 22:57:51 PST
All reviewed patches have been landed.  Closing bug.