Bug 74542 - Implement flexDirection and flexWrap and make flexFlow a proper shorthand.
Summary: Implement flexDirection and flexWrap and make flexFlow a proper shorthand.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Ojan Vafai
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-12-14 14:46 PST by Ojan Vafai
Modified: 2011-12-14 15:39 PST (History)
4 users (show)

See Also:


Attachments
Patch (36.00 KB, patch)
2011-12-14 14:48 PST, Ojan Vafai
tony: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Ojan Vafai 2011-12-14 14:46:38 PST
Implement flexDirection and flexWrap and make flexFlow a proper shorthand.
Comment 1 Ojan Vafai 2011-12-14 14:48:19 PST
Created attachment 119302 [details]
Patch
Comment 2 Tony Chang 2011-12-14 15:20:20 PST
Comment on attachment 119302 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=119302&action=review

Maybe add a test case that sets (direction|wrap) and flow and the last one set wins.

> LayoutTests/css3/flexbox/script-tests/css-properties.js:154
> +    shouldBeEqualToString('flexbox.style.webkitFlexFlow', (expected).replace(/^ /, '').replace(/ $/, ''));

Nit: Remove () around expected.
Comment 3 Ojan Vafai 2011-12-14 15:39:36 PST
Committed r102837: <http://trac.webkit.org/changeset/102837>