Bug 74534 - Web Inspector: CodeGeneratorInspector.py convert script conditions to precompiler #ifs
Summary: Web Inspector: CodeGeneratorInspector.py convert script conditions to precomp...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (Deprecated) (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks: 72861
  Show dependency treegraph
 
Reported: 2011-12-14 13:15 PST by Peter Rybin
Modified: 2011-12-15 06:20 PST (History)
11 users (show)

See Also:


Attachments
Patch (10.96 KB, patch)
2011-12-14 17:49 PST, Peter Rybin
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Peter Rybin 2011-12-14 13:15:21 PST
Currently generator generates different outputs depending on command-line parameters.
Re-implement it so that output is always the same, but has precompiler #ifs.
This is cleaner.
Comment 1 Peter Rybin 2011-12-14 17:49:15 PST
Created attachment 119352 [details]
Patch
Comment 2 Ilya Tikhonovsky 2011-12-14 21:38:15 PST
please attach samples of the generated files.
Comment 3 Ilya Tikhonovsky 2011-12-15 06:20:02 PST
Comment on attachment 119352 [details]
Patch

Clearing flags on attachment: 119352

Committed r102933: <http://trac.webkit.org/changeset/102933>
Comment 4 Ilya Tikhonovsky 2011-12-15 06:20:09 PST
All reviewed patches have been landed.  Closing bug.