Bug 74531 - Filter amounts should accept percentages
Summary: Filter amounts should accept percentages
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: CSS (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Simon Fraser (smfr)
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2011-12-14 12:50 PST by Dean Jackson
Modified: 2011-12-16 13:41 PST (History)
6 users (show)

See Also:


Attachments
Patch (19.96 KB, patch)
2011-12-14 17:25 PST, Simon Fraser (smfr)
cmarrin: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Dean Jackson 2011-12-14 12:50:15 PST
Filter shorthands like grayscale() should accept % values. See the spec for reference.
Comment 1 Radar WebKit Bug Importer 2011-12-14 12:50:58 PST
<rdar://problem/10581759>
Comment 2 Simon Fraser (smfr) 2011-12-14 17:25:03 PST
Created attachment 119346 [details]
Patch
Comment 3 Simon Fraser (smfr) 2011-12-14 17:30:54 PST
http://trac.webkit.org/changeset/102855
Comment 4 Luke Macpherson 2011-12-14 18:08:48 PST
Comment on attachment 119346 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=119346&action=review

> Source/WebCore/css/CSSStyleSelector.cpp:5356
> +                if (firstValue->primitiveType() == CSSPrimitiveValue::CSS_PERCENTAGE)

You can just use firstValue->isPercentage() here.
Comment 5 Dean Jackson 2011-12-16 13:41:28 PST
(In reply to comment #4)
> (From update of attachment 119346 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=119346&action=review
> 
> > Source/WebCore/css/CSSStyleSelector.cpp:5356
> > +                if (firstValue->primitiveType() == CSSPrimitiveValue::CSS_PERCENTAGE)
> 
> You can just use firstValue->isPercentage() here.

I'll change this in https://bugs.webkit.org/show_bug.cgi?id=74736