Bug 74530 – [chromium] Compositor needs to set texture filtering on canvas layers

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Adrienne Walker]

[chromium] Compositor needs to set texture filtering on canvas layers

[Adrienne Walker]

Created attachment 119276 [details]
Patch

[Adrienne Walker]

Other layers (WebGL, plugin) set texture filtering to linear.  The canvas layer just takes whatever's on the texture it's been given, which happens to be linear.  Set it explicitly instead.

See: http://code.google.com/p/chromium/issues/detail?id=101928

[James Robinson]

Comment on attachment 119276 [details]
Patch

R=me, but it seems a bit silly to do it here. tex parameters are associated with the texture, not a particular binding, so we should only do this once when we create the texture.

[Adrienne Walker]

(In reply to comment #3)
> (From update of attachment 119276 [details])
> R=me, but it seems a bit silly to do it here. tex parameters are associated with the texture, not a particular binding, so we should only do this once when we create the texture.

I'm not totally convinced of that.  When canvas switches to using a ManagedTexture, it's possible that its texture could be recycled from some texture that has different settings.

[James Robinson]

In that case the recycling should preserve any texParameters. I agree that it probably doesn't today (grumble about crappy recycling code).

[WebKit Review Bot]

Comment on attachment 119276 [details]
Patch

Clearing flags on attachment: 119276

Committed r102828: <http://trac.webkit.org/changeset/102828>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.