Bug 74530 - [chromium] Compositor needs to set texture filtering on canvas layers
Summary: [chromium] Compositor needs to set texture filtering on canvas layers
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Adrienne Walker
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-12-14 12:37 PST by Adrienne Walker
Modified: 2011-12-14 14:38 PST (History)
5 users (show)

See Also:


Attachments
Patch (1.82 KB, patch)
2011-12-14 12:38 PST, Adrienne Walker
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Adrienne Walker 2011-12-14 12:37:11 PST
[chromium] Compositor needs to set texture filtering on canvas layers
Comment 1 Adrienne Walker 2011-12-14 12:38:17 PST
Created attachment 119276 [details]
Patch
Comment 2 Adrienne Walker 2011-12-14 12:39:53 PST
Other layers (WebGL, plugin) set texture filtering to linear.  The canvas layer just takes whatever's on the texture it's been given, which happens to be linear.  Set it explicitly instead.

See: http://code.google.com/p/chromium/issues/detail?id=101928
Comment 3 James Robinson 2011-12-14 12:47:46 PST
Comment on attachment 119276 [details]
Patch

R=me, but it seems a bit silly to do it here. tex parameters are associated with the texture, not a particular binding, so we should only do this once when we create the texture.
Comment 4 Adrienne Walker 2011-12-14 12:50:41 PST
(In reply to comment #3)
> (From update of attachment 119276 [details])
> R=me, but it seems a bit silly to do it here. tex parameters are associated with the texture, not a particular binding, so we should only do this once when we create the texture.

I'm not totally convinced of that.  When canvas switches to using a ManagedTexture, it's possible that its texture could be recycled from some texture that has different settings.
Comment 5 James Robinson 2011-12-14 12:52:57 PST
In that case the recycling should preserve any texParameters. I agree that it probably doesn't today (grumble about crappy recycling code).
Comment 6 WebKit Review Bot 2011-12-14 14:38:24 PST
Comment on attachment 119276 [details]
Patch

Clearing flags on attachment: 119276

Committed r102828: <http://trac.webkit.org/changeset/102828>
Comment 7 WebKit Review Bot 2011-12-14 14:38:28 PST
All reviewed patches have been landed.  Closing bug.