Bug 74527 - DFG relies on returning a struct in registers
Summary: DFG relies on returning a struct in registers
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Gavin Barraclough
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-12-14 11:29 PST by Gavin Barraclough
Modified: 2011-12-14 12:51 PST (History)
0 users

See Also:


Attachments
fix (3.63 KB, patch)
2011-12-14 11:31 PST, Gavin Barraclough
ggaren: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Gavin Barraclough 2011-12-14 11:29:51 PST
This will not work on all platforms.  Returning a uint64_t will more reliably achieve what we want, on 32-bit platforms (on 64-bit, stick with the struct return).
Comment 1 Gavin Barraclough 2011-12-14 11:31:38 PST
Created attachment 119264 [details]
fix
Comment 2 Geoffrey Garen 2011-12-14 11:38:10 PST
Comment on attachment 119264 [details]
fix

r=me
Comment 3 Gavin Barraclough 2011-12-14 12:51:36 PST
Fixed in r102811