Bug 74526 - [Qt][WK2] Setting Download as action for navigation request crashes WebProcess
Summary: [Qt][WK2] Setting Download as action for navigation request crashes WebProcess
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit Qt (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC Linux
: P2 Normal
Assignee: Jesus Sanchez-Palencia
URL:
Keywords: Qt, QtTriaged
Depends on:
Blocks: 74541
  Show dependency treegraph
 
Reported: 2011-12-14 11:26 PST by Rafael Brandao
Modified: 2011-12-15 05:19 PST (History)
1 user (show)

See Also:


Attachments
This adds simple handler to navigation request on MiniBrowser, so you can see it crashing. (1.19 KB, patch)
2011-12-14 11:27 PST, Rafael Brandao
no flags Details | Formatted Diff | Diff
Patch (1.67 KB, patch)
2011-12-14 14:44 PST, Jesus Sanchez-Palencia
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Rafael Brandao 2011-12-14 11:26:28 PST
An easy way to check this out is to handle onNavigationRequested on MiniBrowser for example. I`ve added a small diff that adds this feature on MiniBrowser. In order to crash it, just click with middle button on any link. You'll see the following output:

We are supposed to start a download.
WARNING: The web process experienced a crash on 'http://www.google.com.br/'.
Comment 1 Rafael Brandao 2011-12-14 11:27:19 PST
Created attachment 119262 [details]
This adds simple handler to navigation request on MiniBrowser, so you can see it crashing.
Comment 2 Jesus Sanchez-Palencia 2011-12-14 13:53:07 PST
Backtrace shows that this is not related to the Download code path itself but to ResouceRequest and ThirdPartyCookies. IIRC, this has been recently refactored by Simon. I will talk to him.

#0  0x00007f59a4c1bd1a in WebCore::thirdPartyCookiePolicyPermits Source/WebCore/platform/qt/ThirdPartyCookiesQt.cpp:65

#1  0x00007f59a4c0829d in WebCore::ResourceRequest::toNetworkRequest Source/WebCore/platform/network/qt/ResourceRequestQt.cpp:83

#2  0x00007f59a407ce55 in WebKit::Download::start
Source/WebKit2/WebProcess/Downloads/qt/DownloadQt.cpp:48
Comment 3 Jesus Sanchez-Palencia 2011-12-14 14:44:57 PST
Created attachment 119301 [details]
Patch
Comment 4 Jesus Sanchez-Palencia 2011-12-15 05:18:56 PST
Comment on attachment 119301 [details]
Patch

Clearing flags on attachment: 119301

Committed r102926: <http://trac.webkit.org/changeset/102926>
Comment 5 Jesus Sanchez-Palencia 2011-12-15 05:19:05 PST
All reviewed patches have been landed.  Closing bug.