Bug 74523 – [GTK] Page size should be 0,0 when view widget is not realized

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKit2

[Carlos Garcia Campos]

For consistency with WebCore that uses 0,0 as empty size. GTK+ initializes the widget allocation as -1, -1, 1, 1.

[Carlos Garcia Campos]

Created attachment 119254 [details]
Patch

[Martin Robinson]

Comment on attachment 119254 [details]
Patch

How did you notice this? Did it cause a bug somewhere?

[WebKit Review Bot]

Thanks for the patch. If this patch contains new public API please make sure it follows the guidelines for new WebKit2 GTK+ API. See http://trac.webkit.org/wiki/WebKitGTK/AddingNewWebKit2API

[Carlos Garcia Campos]

(In reply to comment #2)
> (From update of attachment 119254 [details])
> How did you notice this? Did it cause a bug somewhere?

Writing the unit test for the window properties patch. 

I do someting like window.open('', '', 'left=10,top=20,width=800,height=600');

and I get 10, 20, 799, 599 from WindowFeatures, because in FrameLoader::createWindow() the window size is adjusted for the difference between the window size and the page size:

if (features.widthSet)
        windowRect.setWidth(features.width + (windowRect.width() - pageSize.width()));
if (features.heightSet)
        windowRect.setHeight(features.height + (windowRect.height() - pageSize.height()));

initially the window rect is 0, 0 and page size is 1, 1

[Carlos Garcia Campos]

Committed r102804: <http://trac.webkit.org/changeset/102804>