Bug 7452 – <wbr> in <pre> causes some new lines to be ignored

• Status: RESOLVED
• Resolution: FIXED
• Component: DOM

[Sam Weinig]

If you get the automatic commit emails from [webkit-changes] on Gmail you probably will have seen this bug.  Since the switch to the fancy formatting for the emails many lines have gone way off the page due to not line breaking, making it a pain to read.  The culprit it seems, is that when the <wbr> tag is inside a <pre>, useful for, among other things, breaking long paths nicely, line endings are ignored until the end of the <pre> or another <wbr> is found.

[Sam Weinig]

Created attachment 6709 [details]
test case

Test case showing bad behavior.  In Firefox, the line break is made.

See also bug 10657.

[Darin Adler]

<rdar://problem/3211749>

[Darin Adler]

Created attachment 14449 [details]
patch that implements proper parsing and rendering for <wbr>

Comment on attachment 14449 [details]
patch that implements proper parsing and rendering for <wbr>

+++ WebCore/dom/Node.cpp	(working copy)

Please include the changes to Node.cpp in the change log. Did you actually hit a case where createRenderer() returned 0 despite rendererIsNeeded() returning true? If not, can you replace or augment the if(r) with an ASSERT(r)?

What's the following all about?

Property changes on: LayoutTests/fast/text/wbr.html
___________________________________________________________________
Name: svn:executable
   + *

r=me

[Darin Adler]

> Please include the changes to Node.cpp in the change log. Did you actually hit
> a case where createRenderer() returned 0 despite rendererIsNeeded() returning
> true? If not, can you replace or augment the if(r) with an ASSERT(r)?

I crashed while running layout tests. I didn't investigate this in great detail, and I forgot about it completely!

I thought it was an obvious mistake that there was a null check on one line and no null check on the next line.

> What's the following all about? [executable flag on some files]

Not sure -- obviously my mistake.

[Darin Adler]

Committed revision 21405.