Bug 74518 - Create reftest for render-region-renderer
Summary: Create reftest for render-region-renderer
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: CSS (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-12-14 10:36 PST by Larry McLister
Modified: 2011-12-15 16:37 PST (History)
3 users (show)

See Also:

Attachments
Patch (9.18 KB, patch)
2011-12-14 11:36 PST, Larry McLister 		no flags Details | Formatted Diff | Diff
Patch (10.17 KB, patch)
2011-12-14 11:43 PST, Larry McLister 		tony: review+
tony: commit-queue-
Details | Formatted Diff | Diff
Patch (10.79 KB, patch)
2011-12-14 16:03 PST, Larry McLister 		no flags Details | Formatted Diff | Diff
Updated patch (10.16 KB, patch)
2011-12-15 11:42 PST, Larry McLister 		no flags Details | Formatted Diff | Diff
Show Obsolete (3) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Larry McLister 2011-12-14 10:36:32 PST 
This regions test should be converted to a reftest from a bitmap test.

LayoutTests/fast/regions/render-region-renderer
Comment 1 Larry McLister 2011-12-14 11:36:28 PST 
Created attachment 119266 [details]
Patch
Comment 2 Larry McLister 2011-12-14 11:43:44 PST 
Created attachment 119269 [details]
Patch
Comment 3 Tony Chang 2011-12-14 15:52:51 PST 
Comment on attachment 119269 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=119269&action=review

> LayoutTests/fast/regions/render-region-renderer-expected.html:57
> +	    <div class="border size"></div>
> +	    <div class="border size pos"></div>
> +	
> +	    <div class="border size2 pos1"></div>

Nit: Indention is weird.

> LayoutTests/fast/regions/render-region-renderer-expected.html:58
> +    	<div class="region border size2 pos2 outline"></div>

Nit: Remove |region|?
Comment 4 Larry McLister 2011-12-14 16:03:55 PST 
Created attachment 119313 [details]
Patch
Comment 5 Larry McLister 2011-12-15 11:42:32 PST 
Created attachment 119474 [details]
Updated patch
Comment 6 WebKit Review Bot 2011-12-15 16:37:24 PST 
Comment on attachment 119474 [details]
Updated patch

Clearing flags on attachment: 119474

Committed r102997: <http://trac.webkit.org/changeset/102997>
Comment 7 WebKit Review Bot 2011-12-15 16:37:29 PST 
All reviewed patches have been landed.  Closing bug.