Bug 74507 - Minor refactor to Parser::parseTryStatement
Summary: Minor refactor to Parser::parseTryStatement
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-12-14 08:37 PST by Andy Wingo
Modified: 2011-12-15 05:46 PST (History)
3 users (show)

See Also:


Attachments
Patch (1.68 KB, patch)
2011-12-14 08:38 PST, Andy Wingo
no flags Details | Formatted Diff | Diff
Patch (20.37 KB, patch)
2011-12-14 09:03 PST, Andy Wingo
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Andy Wingo 2011-12-14 08:37:06 PST
Currently, the parser binds an identifier for the exception of a `catch' block by going directly to the scope object.  The patch to be attached makes it use the Parser object's method.  This will facilitate future checks for conflicting block-scoped bindings.
Comment 1 Andy Wingo 2011-12-14 08:38:22 PST
Created attachment 119223 [details]
Patch
Comment 2 Andy Wingo 2011-12-14 09:03:45 PST
Created attachment 119229 [details]
Patch
Comment 3 Andy Wingo 2011-12-14 09:04:54 PST
Comment on attachment 119229 [details]
Patch

Sorry, uploaded this patch to the wrong bug.  The previous one is the right one.
Comment 4 Geoffrey Garen 2011-12-14 10:37:51 PST
Comment on attachment 119223 [details]
Patch

r=me
Comment 5 WebKit Review Bot 2011-12-15 05:46:12 PST
Comment on attachment 119223 [details]
Patch

Clearing flags on attachment: 119223

Committed r102931: <http://trac.webkit.org/changeset/102931>
Comment 6 WebKit Review Bot 2011-12-15 05:46:17 PST
All reviewed patches have been landed.  Closing bug.